From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbbJQJ4E (ORCPT ); Sat, 17 Oct 2015 05:56:04 -0400 Received: from lists.s-osg.org ([54.187.51.154]:34050 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbbJQJ4A (ORCPT ); Sat, 17 Oct 2015 05:56:00 -0400 Subject: Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks To: Krzysztof Kozlowski , Kukjin Kim , Michael Turquette References: <1444905084-22540-1-git-send-email-tomeu.vizoso@collabora.com> <1444905084-22540-2-git-send-email-tomeu.vizoso@collabora.com> <56203AD3.2050905@samsung.com> <20151016124935.20687.4394@quantum> <20151016172651.GB23912@codeaurora.org> <56218B2D.9040007@kernel.org> Cc: Tomeu Vizoso , Stephen Boyd , "linux-kernel@vger.kernel.org" , Gustavo Padovan , Seung-Woo Kim , Inki Dae , Kyungmin Park , Joonyoung Shim , "devicetree@vger.kernel.org" , Kumar Gala , Ian Campbell , linux-samsung-soc , Sylwester Nawrocki , Pawel Moll , Rob Herring , Mark Rutland , Tomasz Figa , linux-clk@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Message-ID: <56221B26.2050407@osg.samsung.com> Date: Sat, 17 Oct 2015 11:55:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 10/17/2015 10:53 AM, Krzysztof Kozlowski wrote: > 2015-10-17 8:41 GMT+09:00 Kukjin Kim : [snip] >>> >> So...how can I take 2nd patch of this series in samsung(arm-soc) tree? >> And this series shouldn't be for fixes for 4.3?...Mike how do you think? > > Stephen acked it so I thought everything will go through samsung-soc. > > Dear Kukjin, > Indeed this can go as fix for current cycle... but in the same time > this does not fix any specific regression. Tomeu did not describe when > issue happened for the first time so I assumed it was like that > always. It's up to you. > Sorry for not answering about this series before but I've been in contact with Tomeu over IRC before he posted it and since you already added your Reviewed-by tag, I didn't feel the need do to it. This is a regression for 4.3 since S2R was working correctly for 4.2 in Snow, I tested after fixing resume with commit 6fd4899a54a5 ("irqchip: exynos-combiner: Save IRQ enable set on suspend") and the display was always enabled on resume. I don't have access to a Snow anymore to bisect but I think the regression was introduced by some of the changes in 4.3 to migrate the Exynos DRM to Atomic Mode Settings. But probably that just exposed a latent bug and it was working out of luck since I had the same issue than Tomeu in Exynos5420 and was fixed in the same way with commits: 885601002998 ("clk: exynos5420: Add IDs for clocks used in DISP1 power domain") ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") > Both patches (with Stephen's ack) are in my recent pull request but as > usual feel free to cherry pick. I'll drop them from next branch then. > > Best regards, > Krzysztof > -- Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America