From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751685AbbJQT6e (ORCPT ); Sat, 17 Oct 2015 15:58:34 -0400 Received: from h1446028.stratoserver.net ([85.214.92.142]:40263 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984AbbJQT6d (ORCPT ); Sat, 17 Oct 2015 15:58:33 -0400 Subject: Re: [PATCH 04/14] init: deps: order network interfaces by link order To: Greg Kroah-Hartman References: <1445102067-11519-1-git-send-email-holler@ahsoftware.de> <1445102067-11519-5-git-send-email-holler@ahsoftware.de> <5622956F.80408@ahsoftware.de> <56229B0B.80100@ahsoftware.de> <56229E1A.8010803@ahsoftware.de> <20151017193606.GA2315@kroah.com> Cc: Linux Kernel Mailing List , Andrew Morton , Russell King , Grant Likely From: Alexander Holler Message-ID: <5622A861.6020906@ahsoftware.de> Date: Sat, 17 Oct 2015 21:58:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20151017193606.GA2315@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 17.10.2015 um 21:36 schrieb Greg Kroah-Hartman: > On Sat, Oct 17, 2015 at 09:14:34PM +0200, Alexander Holler wrote: >> Am 17.10.2015 um 21:08 schrieb Linus Torvalds: >>> On Sat, Oct 17, 2015 at 12:01 PM, Alexander Holler wrote: >>>> >>>> That isn't a flag day thing. It's a config option everyone can turn on and >>>> off whenever he wants. >>> >>> That's a flag-day thing. We've done it (drm comes to mind - several times). >>> >>> I'm disappointed, because I _know_ I pointed you in the direction of >>> stable sorting about a month ago. I really had hoped you'd have taken >>> that into account. >> >> It's impossible to take it into account because I don't want to miss the >> parallelize functionality. And without that, all the stuff doesn't offer >> enough benefits to be worse the effort but just adds some time necessary to >> do the sorting. It might solve the deferred probe problems, but without much >> benefit. > > Again, parallelizing does not solve anything, and causes more problems > _and_ makes things take longer. Try it, we have done it in the past and > proven this, it's pretty easy to test :) I've tested it, otherwise I wouldn't have posted the patches. Unfortunately it's quiet a lot of work to add dependencies for everything. So maybe I'm able to offer some better numbers in a year or such, when I was bored often enough to add more dependencies for initcalls. Not to mention that small changes in the order can have quiet big differences in the boot time, so it's quiet hard to parallelize stuff (add dependencies) correctly like e.g. the pci/acpi/processor stuff. Especially because many reasons for the current order aren't mentioned in the source and are hard to see without specific knowledge about the HW. Alexander Holler