From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbbJQUfT (ORCPT ); Sat, 17 Oct 2015 16:35:19 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35666 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbbJQUfN (ORCPT ); Sat, 17 Oct 2015 16:35:13 -0400 Subject: Re: [RFC PATCH 0/7] perf tools: Config BPF maps through perf cmdline To: Wang Nan , acme@kernel.org, brendan.d.gregg@gmail.com References: <1445078910-73699-1-git-send-email-wangnan0@huawei.com> Cc: a.p.zijlstra@chello.nl, daniel@iogearbox.net, dsahern@gmail.com, hekuang@huawei.com, jolsa@kernel.org, lizefan@huawei.com, masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org, paulus@samba.org, linux-kernel@vger.kernel.org, pi3orama@163.com, xiakaixu@huawei.com From: Alexei Starovoitov Message-ID: <5622B101.9070404@plumgrid.com> Date: Sat, 17 Oct 2015 13:35:13 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445078910-73699-1-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/15 3:48 AM, Wang Nan wrote: > In these 7 patches: > > 1. perf is able to put values into map: > # perf record -e mybpf.c/maps.values.value=1234/ ... > > 2. perf is able to control different slots in a map separately: > # perf record -e mybpf.c/maps.values.value[1,4-6]=1234,maps.values.value[0,2-3]=5678/ ... > > 3. The second syntax can be applied to perf event also: > # perf record -v -a -e evt=cycles -e mybpf.c/maps.pmu_map.event[0]=evt/ ... > > 4. Compatible with the old syntax: > # perf record -v -a -e evt=cycles -e mybpf.c/maps.pmu_map.event=evt/ ... The concept looks good and solves real need. No opinion on implementation.