From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752150AbbJRAEn (ORCPT <rfc822;w@1wt.eu>);
	Sat, 17 Oct 2015 20:04:43 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:63367 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752008AbbJRAEm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 17 Oct 2015 20:04:42 -0400
Message-ID: <5622E0AA.3030908@huawei.com>
Date: Sun, 18 Oct 2015 07:58:34 +0800
From: "Wangnan (F)" <wangnan0@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Alexei Starovoitov <ast@plumgrid.com>, <acme@kernel.org>,
        <brendan.d.gregg@gmail.com>
CC: <a.p.zijlstra@chello.nl>, <daniel@iogearbox.net>, <dsahern@gmail.com>,
        <hekuang@huawei.com>, <jolsa@kernel.org>, <lizefan@huawei.com>,
        <masami.hiramatsu.pt@hitachi.com>, <namhyung@kernel.org>,
        <paulus@samba.org>, <linux-kernel@vger.kernel.org>, <pi3orama@163.com>,
        <xiakaixu@huawei.com>
Subject: Re: [RFC PATCH 0/7] perf tools: Config BPF maps through perf cmdline
References: <1445078910-73699-1-git-send-email-wangnan0@huawei.com> <5622B101.9070404@plumgrid.com>
In-Reply-To: <5622B101.9070404@plumgrid.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090202.5622E0BE.0046,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 7a37f351cc139a4e6578ac3949b441d3
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2015/10/18 4:35, Alexei Starovoitov wrote:
> On 10/17/15 3:48 AM, Wang Nan wrote:
>> In these 7 patches:
>>
>>   1. perf is able to put values into map:
>>    # perf record -e mybpf.c/maps.values.value=1234/ ...
>>
>>   2. perf is able to control different slots in a map separately:
>>    # perf record -e 
>> mybpf.c/maps.values.value[1,4-6]=1234,maps.values.value[0,2-3]=5678/ ...
>>
>>   3. The second syntax can be applied to perf event also:
>>    # perf record -v -a -e evt=cycles -e 
>> mybpf.c/maps.pmu_map.event[0]=evt/ ...
>>
>>   4. Compatible with the old syntax:
>>    # perf record -v -a -e evt=cycles -e 
>> mybpf.c/maps.pmu_map.event=evt/ ...
>
> The concept looks good and solves real need.
> No opinion on implementation.
>
Can I translate these words into an acked-by?

And what's your PERF_COUNT_SW_BPF_OUTPUT going on? I think based on this
patchset you can test it with perf now.

Thank you.