From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752928AbbJRJ4B (ORCPT <rfc822;w@1wt.eu>);
	Sun, 18 Oct 2015 05:56:01 -0400
Received: from mout.web.de ([212.227.17.12]:63131 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752035AbbJRJz7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 18 Oct 2015 05:55:59 -0400
Subject: Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree
To: Julia Lawall <Julia.Lawall@lip6.fr>
References: <1445102605-22408-1-git-send-email-Julia.Lawall@lip6.fr>
Cc: Fabian Frederick <fabf@skynet.be>, Gilles Muller <Gilles.Muller@lip6.fr>,
        Michal Marek <mmarek@suse.com>, Nicolas Palix <nicolas.palix@imag.fr>,
        cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <56236C9A.8060906@users.sourceforge.net>
Date: Sun, 18 Oct 2015 11:55:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1445102605-22408-1-git-send-email-Julia.Lawall@lip6.fr>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:aPY3aSbQJiLQ30P6mIolN09mHsYh0aqYHk39lrWli63BlNYHIq+
 InXUWE5hSxeQqq54+gp5wNnVjDWQtC5TEHNqlyl5NAvDgl8FCf3mwUZHBB9cSX+MSdKsd/T
 oIAksE4zwLCYepD2G1Jfm/t6sQFNJoynby3TaLbbdSChX+RqKZIV6zEovLr0E9TtHMrfMTn
 KBXvfpzG99JTzLCkXo0yA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:/286FlUKYs0=:tHgyGJAICwS2P36o1semzR
 RjAIyUcfdnIFADMCpM9nxJlgDJSY7ZPF3iR1G5oaWZnF1zdKW2Wm+1NsLrg0ie9kb+08pdh/0
 pVczeU1cr9J40sk05TFymQP3MyhLSo9LrhV18FRLSS8Sz6WbsbbloO6dEroQf3tUnX0S4OJi0
 G/0razHPsHSlQeHPhRyemTrcmBQN8KyKOtRLiMB9op+ubfxBxHB8L23wyOHQAINFIInHm0RyV
 vww52m1eAnx8HztXkjEpAUuBiwo9b0rhekWNuCWKZ/w1njAdTjzZp6dIQ8NN85YFfqsBVSqHT
 wg/MTCYLGROUdIOOKjXRSMoQAtApzpAtPHkl8YNpMGriGTe3J3a8qhX7tDy8viBVG9DWpuMoX
 hLfVcSOllI0v5KUQYb9XML2B7ODf2P5pTsjTJ6e93QjYU9PhNsGqsUZqm6F6EwS2BxzoE1ZWf
 jFqKSUGB75fckDXC+8A7/2z1+9w7Z5JWt9PTc1alC6Q79P452dmpvrPiPaVB006oy1I3oyGE+
 KRLkIBMKo+6xnDWCQ9O5Dc9XnnOTeChDzCqPEz0+o3fDPuGf5QUt0cp0TI2IE/HdKh9vfFlAr
 R8kfglW1b82cAfQGgoL3sNemxZaAYraGEuGnyUieXAoPPk0FLFrxnxY/IUMuhFDSmjbXZFMlG
 SolVe1ZvngG2CKDCj9IdjMaZK2K0eiEoh/Sl5eSnWYCYm4twJ2hIk4DcnaEWMYUtwQ6lzG4nr
 4BLH9NFk7lmQhk1L/2X+q9h5IZ5KRUx4GVu1n5jBlC42MAOJO0TJasg9Up2oVFapZc4gMC2Fb
 f5BGmp1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Remove removal and re-addition of freeing functions.

I find such a wording confusing for a commit message.


> Add position variable on usb_free_urb in the non-patch case.

Is it interesting that this fix corresponds to a bug report from 2014-08-09?
https://lkml.org/lkml/2014/8/9/33
https://systeme.lip6.fr/pipermail/cocci/2014-August/001038.html


>  @r depends on context || report || org @
> @@ -36,8 +32,8 @@ expression E;
>  position p;
>  @@
>  
> -* if (E)
> -*	\(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb\)(E);
> +* if (E != NULL)
> +*	\(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb@p\)(E);

How do you think about to extend the shown function name pattern
also with suffixes like the following (besides "destroy")?
* put
* release
* unref
* unregister

Regards,
Markus