From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752482AbbJRLBM (ORCPT <rfc822;w@1wt.eu>);
	Sun, 18 Oct 2015 07:01:12 -0400
Received: from mail-lb0-f182.google.com ([209.85.217.182]:36258 "EHLO
	mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751716AbbJRLBJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 18 Oct 2015 07:01:09 -0400
Subject: Re: [PATCH v10 3/3] arm64: dts: mediatek: add xHCI & usb phy for
 mt8173
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
        Mathias Nyman <mathias.nyman@intel.com>
References: <1445140279-18121-1-git-send-email-chunfeng.yun@mediatek.com>
 <1445140279-18121-4-git-send-email-chunfeng.yun@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Matthias Brugger <matthias.bgg@gmail.com>, Felipe Balbi <balbi@ti.com>,
        Sascha Hauer <s.hauer@pengutronix.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Roger Quadros <rogerq@ti.com>, linux-usb@vger.kernel.org,
        linux-mediatek@lists.infradead.org, John Crispin <blogic@openwrt.org>,
        Daniel Kurtz <djkurtz@chromium.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <56237BF2.5070809@cogentembedded.com>
Date: Sun, 18 Oct 2015 14:01:06 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1445140279-18121-4-git-send-email-chunfeng.yun@mediatek.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 10/18/2015 6:51 AM, Chunfeng Yun wrote:

> add xHCI and phy drivers for MT8173-EVB
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

[...]

> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index d18ee42..46f5f50 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
[...]
> @@ -487,6 +488,47 @@
>   			clock-names = "source", "hclk";
>   			status = "disabled";
>   		};
> +
> +		usb30: usb@11270000 {
> +			compatible = "mediatek,mt8173-xhci";
> +			reg = <0 0x11270000 0 0x1000>,
> +			      <0 0x11280700 0 0x0100>;
> +			interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_LOW>;
> +			power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>;
> +			clocks = <&topckgen CLK_TOP_USB30_SEL>,
> +				 <&pericfg CLK_PERI_USB0>,
> +				 <&pericfg CLK_PERI_USB1>;
> +			clock-names = "sys_ck",
> +				      "wakeup_deb_p0",
> +				      "wakeup_deb_p1";
> +			phys = <&phy_port0 PHY_TYPE_USB3>,
> +			       <&phy_port1 PHY_TYPE_USB2>;
> +			mediatek,syscon-wakeup = <&pericfg>;
> +			status = "okay";
> +		};
> +
> +		u3phy: usb-phy@11290000 {
> +			compatible = "mediatek,mt8173-u3phy";
> +			reg = <0 0x11290000 0 0x800>;
> +			clocks = <&apmixedsys CLK_APMIXED_REF2USB_TX>;
> +			clock-names = "u3phya_ref";
> +			#address-cells = <2>;
> +			#size-cells = <2>;
> +			ranges;
> +			status = "okay";

    Don't you need the "power-domains" prop here as well?

> +
> +			phy_port0: port@11290800 {
> +				reg = <0 0x11290800 0 0x800>;
> +				#phy-cells = <1>;
> +				status = "okay";
> +			};
> +
> +			phy_port1: port@11291000 {
> +				reg = <0 0x11291000 0 0x800>;
> +				#phy-cells = <1>;
> +				status = "okay";
> +			};
> +		};
>   	};
>   };
>

MBR, Sergei