From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752790AbbJSCoU (ORCPT ); Sun, 18 Oct 2015 22:44:20 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:34720 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbbJSCoS (ORCPT ); Sun, 18 Oct 2015 22:44:18 -0400 Subject: Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test To: Greg KH , punit vara References: <1444847155-11243-1-git-send-email-punitvara@gmail.com> <1444847155-11243-5-git-send-email-punitvara@gmail.com> <20151017051635.GA3074@kroah.com> <20151019020020.GB8496@kroah.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Julia Lawall , Sudip Mukherjee , Dan Carpenter From: Larry Finger Message-ID: <56245902.7070202@lwfinger.net> Date: Sun, 18 Oct 2015 21:44:18 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151019020020.GB8496@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/2015 09:00 PM, Greg KH wrote: > On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: >> One more thing I would like suggestion how can start switching this >> driver to LIB80211 ,MAC80211 ? Which is the first file I should focus >> ? Simultaneously I am trying to understand the flow of driver . I >> would like to know the start point from where I can start doing small >> changes. > > If you don't understand the wireless stack, I suggest you do some > research on it first, converting a driver to the in-kernel stack is a > _very_ difficult thing and not something that someone without any > experience in this area is going to be able to do easily. I second this suggestion. Your skill level is not nearly sufficient for this sort of task. Note that there is a group working on driver rtl8192su, which should be able to replace rtl8712u. The participants are very highly skilled wireless developers; however, they are having trouble. The internals of the Realtek chips are not revealed to anyone in any form other than the code they release. Larry