From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbbJSIQR (ORCPT ); Mon, 19 Oct 2015 04:16:17 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:43391 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753219AbbJSIQN (ORCPT ); Mon, 19 Oct 2015 04:16:13 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-35-5624a6cadfea Message-id: <5624A6C9.8080806@samsung.com> Date: Mon, 19 Oct 2015 10:16:09 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Fida Mohammad Cc: Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: leds-locomo.c: Use devm_led_classdev_register References: <1445031183-25326-1-git-send-email-fmthoker@gmail.com> In-reply-to: <1445031183-25326-1-git-send-email-fmthoker@gmail.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsVy+t/xq7qnlqmEGfy/om1xdOdEJovV318y WVzeNYfNYuubdYwWu3c9ZXVg9dg56y67x575P1g9Pm+SC2CO4rJJSc3JLEst0rdL4MqY/KuX tWAXT0X//71MDYzdXF2MnBwSAiYSbTOPsELYYhIX7q1n62Lk4hASWMooce3sP2YI5xmjxPFF y5lAqngFtCT+fd7LCGKzCKhKXPvewg5iswkYSvx88RqsRlQgQuLP6X2sEPWCEj8m32MBsUUE 1CQuL/kDZjMLNDJK9LaKgNjCAh4Sn7auApsjJOAkMevLN6DFHBycAs4S01tqIMqtJVZO2sYI YctLbF7zlnkCo8AsJBtmISmbhaRsASPzKkbR1NLkguKk9FxDveLE3OLSvHS95PzcTYyQ4P2y g3HxMatDjAIcjEo8vDfqVcKEWBPLiitzDzFKcDArifD6zAcK8aYkVlalFuXHF5XmpBYfYpTm YFES5527632IkEB6YklqdmpqQWoRTJaJg1OqgTHZokwu3n9lgHLS1zUzTBsOx/krrZlpH9PU WfU6l3v2/U0d+z57uXQsUTQpEAu1WOv62Znlh1uWnfzlYDOmCYYccV4Ori67rqp3Jst79X+6 +k5pesnuI5O3d72dP2nDxj+Wu0MfnbtzuzXQfOrJZVWrIisvFRiZGQp68FhM7E2cIJ3aMnt6 rRJLcUaioRZzUXEiAIq83nNaAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fida, On 10/16/2015 11:33 PM, Fida Mohammad wrote: > Use resource managed function devm_led_classdev_register to make > initialisation path simpler. > Also removed redundant led_classdev_unregister function. > > Signed-off-by: Fida Mohammad > --- > drivers/leds/leds-locomo.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/leds/leds-locomo.c b/drivers/leds/leds-locomo.c > index 80ba048..24c4b53 100644 > --- a/drivers/leds/leds-locomo.c > +++ b/drivers/leds/leds-locomo.c > @@ -59,23 +59,13 @@ static int locomoled_probe(struct locomo_dev *ldev) > { > int ret; > > - ret = led_classdev_register(&ldev->dev, &locomo_led0); > + ret = devm_led_classdev_register(&ldev->dev, &locomo_led0); > if (ret < 0) > return ret; > > - ret = led_classdev_register(&ldev->dev, &locomo_led1); > - if (ret < 0) > - led_classdev_unregister(&locomo_led0); > - > - return ret; > + return devm_led_classdev_register(&ldev->dev, &locomo_led1); > } > > -static int locomoled_remove(struct locomo_dev *dev) > -{ > - led_classdev_unregister(&locomo_led0); > - led_classdev_unregister(&locomo_led1); > - return 0; > -} > > static struct locomo_driver locomoled_driver = { > .drv = { > @@ -83,7 +73,6 @@ static struct locomo_driver locomoled_driver = { > }, > .devid = LOCOMO_DEVID_LED, > .probe = locomoled_probe, > - .remove = locomoled_remove, > }; > > static int __init locomoled_init(void) > Applied, thanks. -- Best Regards, Jacek Anaszewski