From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478AbbJSIQg (ORCPT ); Mon, 19 Oct 2015 04:16:36 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:40487 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753452AbbJSIQc (ORCPT ); Mon, 19 Oct 2015 04:16:32 -0400 X-AuditID: cbfec7f5-f794b6d000001495-2e-5624a6ddf931 Message-id: <5624A6DC.50503@samsung.com> Date: Mon, 19 Oct 2015 10:16:28 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Muhammad Falak R Wani Cc: Chris Boot , Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: leds-net48xx: Use devm_led_classdev_register References: <1445038377-11547-1-git-send-email-falakreyaz@gmail.com> In-reply-to: <1445038377-11547-1-git-send-email-falakreyaz@gmail.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t/xK7p3l6mEGWz7bmax5qirxdGdE5ks dj88z2pxedccNoutb9YxWuze9ZTVgc3j88plLB47Z91l99gz/werx+dNcgEsUVw2Kak5mWWp Rfp2CVwZ+3ZPYi64zFmx5tVTxgbGL+xdjJwcEgImEo1Xv7BB2GISF+6tB7OFBJYySjy4K9XF yAVkP2OUONC0H6yBV0BDYtOUJhYQm0VAVaJvIUQzm4ChxM8Xr5lAbFGBCIk/p/exQtQLSvyY fA+onoNDRMBA4vOnQJCZzAILGSX62leBzREWcJfYefM/E8RiF4mNt1+CxTkFXCW+dPcwg9jM AtYSKydtY4Sw5SU2r3nLPIFRYBaSFbOQlM1CUraAkXkVo2hqaXJBcVJ6rpFecWJucWleul5y fu4mRkg4f93BuPSY1SFGAQ5GJR7eG/UqYUKsiWXFlbmHGCU4mJVEeH3mA4V4UxIrq1KL8uOL SnNSiw8xSnOwKInzztz1PkRIID2xJDU7NbUgtQgmy8TBKdXAaHfiI7+cV+/DCW9/FO7nPif2 Zd5qhff2f8+GRs9/wpdWxK/zos18h+tEpS/lJ0/f6UjLm7reeMm3kI8dlpvWsSmwq031n2L6 yfnLhI8Mb3Lac+/c9bmsFHHIoPTdyhNrF/XO8trw6dqxF/v0k/RtF+j9yq2J0nO3lGzzc9w/ 8+1+v7zE7BcrFJVYijMSDbWYi4oTAbOu/r9jAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Muhammad, On 10/17/2015 01:32 AM, Muhammad Falak R Wani wrote: > Use devm_led_classdev_register instead of led_classdev_register, > removing the redundant net48xx_led_remove function. > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/leds/leds-net48xx.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/leds/leds-net48xx.c b/drivers/leds/leds-net48xx.c > index ec3a2e8..0d214c2 100644 > --- a/drivers/leds/leds-net48xx.c > +++ b/drivers/leds/leds-net48xx.c > @@ -39,18 +39,11 @@ static struct led_classdev net48xx_error_led = { > > static int net48xx_led_probe(struct platform_device *pdev) > { > - return led_classdev_register(&pdev->dev, &net48xx_error_led); > -} > - > -static int net48xx_led_remove(struct platform_device *pdev) > -{ > - led_classdev_unregister(&net48xx_error_led); > - return 0; > + return devm_led_classdev_register(&pdev->dev, &net48xx_error_led); > } > > static struct platform_driver net48xx_led_driver = { > .probe = net48xx_led_probe, > - .remove = net48xx_led_remove, > .driver = { > .name = DRVNAME, > }, > Applied, thanks. -- Best Regards, Jacek Anaszewski