From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753557AbbJSKlC (ORCPT ); Mon, 19 Oct 2015 06:41:02 -0400 Received: from lists.s-osg.org ([54.187.51.154]:34194 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092AbbJSKkd (ORCPT ); Mon, 19 Oct 2015 06:40:33 -0400 Subject: Re: [PATCH v6 0/17] Add Analogix Core Display Port Driver To: Yakir Yang , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , joe@perches.com, Heiko Stuebner , Mark Yao References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1444491357-26095-1-git-send-email-ykk@rock-chips.com> Cc: Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <5624C896.8070108@osg.samsung.com> Date: Mon, 19 Oct 2015 12:40:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444491357-26095-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Yakir, On 10/10/2015 05:35 PM, Yakir Yang wrote: > > Hi all, > > The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller > share the same IP, so a lot of parts can be re-used. I split the common > code into bridge directory, then rk3288 and exynos only need to keep > some platform code. Cause I can't find the exact IP name of exynos dp > controller, so I decide to name dp core driver with "analogix" which I > find in rk3288 eDP TRM :) > > But there are still three light registers setting differents bewteen > exynos and rk3288. > 1. RK3288 have five special pll resigters which not indicata in exynos > dp controller. > 2. The address of DP_PHY_PD(dp phy power manager register) are different > between rk3288 and exynos. > 3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug > register). > > This series have been well tested on Rockchip platform with eDP panel > on Jerry Chromebook and Display Port Monitor on RK3288 board and thanks > to Javier@Samsung help me to find a way to install mainline kernel to > Samsung Exynos Chromebooks, so this series also have been tested on Samsung > Snow and Peach Pit Chromebooks which borrowed from my friends. > > Besides, This version was build on linux-next branch (tag next-20150918), and > the above test experiments also base on that tag. But I know the latest tag is > next-20151009, so i do rebase this series again on next-20151009, there were > little conflicts(exynos_dp removed the suspend/resume). > > But after I retest this series on next-20151009, I saw kernel crashed in mmc > driver(dw_mci_probe failed to get regulator). So i have to disabled the MMC > module(after all I boot with USB device), and I can see eDP light up normally > in startup stage, but kernel keep crashed when it try to mount the filesystem. > I thought this isn't related to dp driver directly, so i choice not to debug > more depth. > > That's to say if someone want to test this series, I suggest you applied this > series on tag-20150918, just need to fix some light conflicts with the 01 & 02 > patches (or just email me, I can send you directly). > > Thanks, Do you have a branch that I can use to test this series? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America