From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbbJSLh4 (ORCPT ); Mon, 19 Oct 2015 07:37:56 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:46848 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbbJSLhz (ORCPT ); Mon, 19 Oct 2015 07:37:55 -0400 X-IronPort-AV: E=Sophos;i="5.17,701,1437436800"; d="scan'208";a="311289776" Message-ID: <5624D5BF.7020605@citrix.com> Date: Mon, 19 Oct 2015 12:36:31 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , CC: Boris Ostrovsky , , , , David Vrabel Subject: Re: [Xen-devel] [PATCH 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages References: <1441999920-3639-1-git-send-email-julien.grall@citrix.com> <1441999920-3639-3-git-send-email-julien.grall@citrix.com> <56129EEF.9090702@citrix.com> <5612ADEB.40002@citrix.com> <561396DF.9040406@citrix.com> <56139B2A.1050809@citrix.com> <56139D0D.4020409@citrix.com> <561BF52B.9020900@citrix.com> <5624D0F5.60207@citrix.com> In-Reply-To: <5624D0F5.60207@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/10/15 12:16, Roger Pau Monné wrote: > At this point I don't think it's worth implementing it, if you feel like > doing that later in order to improve performance that would be fine, but > I don't think it should be required in order to get this merged. I would rather avoid to improve performance in the frontend and encourage people to implement indirect descriptor in their backend. It would be more beneficial for any block frontend (x86, arm, 4K pages, 64K pages...). > I think you had to resend the patch anyway to fix some comments, but > apart from that: Note that I'm planning to update the commit message to summarize my previous mail. > Acked-by: Roger Pau Monné Thank you, I will try to resend a new version today. Regards, -- Julien Grall