From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752603AbbJSMlj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Oct 2015 08:41:39 -0400
Received: from mail-wi0-f180.google.com ([209.85.212.180]:38644 "EHLO
	mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750985AbbJSMlh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Oct 2015 08:41:37 -0400
Subject: Re: [RFC PATCH 1/3] arm: plat-omap: dmtimer: Add clock source from DT
To: Felipe Balbi <balbi@ti.com>, Thierry Reding <thierry.reding@gmail.com>,
        Tony Lindgren <tony@atomide.com>, linux-pwm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-omap@vger.kernel.org, Grant Erickson <marathon96@gmail.com>,
        NeilBrown <neilb@suse.de>, Joachim Eastwood <manabian@gmail.com>
References: <5620ED30.2050507@baylibre.com> <87k2qmlt38.fsf@saruman.tx.rr.com>
From: Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <5624E4F6.5000308@baylibre.com>
Date: Mon, 19 Oct 2015 14:41:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <87k2qmlt38.fsf@saruman.tx.rr.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 10/16/2015 05:40 PM, Felipe Balbi wrote:
>> +static int omap_dm_timer_of_set_source(struct omap_dm_timer *timer)
>> +{
>> +	int ret;
>> +	struct clk *parent;
>> +
>> +	if (unlikely(!timer))
>> +		return -EINVAL;
> 
> IMO, let this crash. If this happens we have bigger problems.
> 
>> +	if (IS_ERR(timer->fclk))
>> +		return -EINVAL;
> 
> We bail out if we can't get fclk, this check is unnecessary.

Sure, I will remove the checks.
This was also breaking OMAP1, fclk must be checked against NULL here to detect OMAP1 and return -ENODEV;

> 
>> +	parent = clk_get(&timer->pdev->dev, NULL);
> 
> why NULL ? You could use something more descriptive, but no strong
> feelings.


Actually, I just wanted the "default" clock for this device, NULL will select the first OF clock found.
If we specify a name, we should also specify it in the DT as clock-names, is it desired ?
If you feel I should name it somehow... I don't want it to conflict all the HWMOD clk namings actually.

> 
>> +	if (IS_ERR(parent))
>> +		return -ENODEV;
>> +
>> +	ret = clk_set_parent(timer->fclk, parent);
>> +	if (ret < 0)
>> +		pr_err("%s: failed to set parent\n", __func__);
>> +
>> +	clk_put(parent);
>> +
>> +	return ret;
>> +}
>> +
>>  static int omap_dm_timer_prepare(struct omap_dm_timer *timer)
>>  {
>> -	int rc;
>> +	int rc, ret;
> 
> doesn't seem like you need this extra 'ret' variable. Just use 'rc'.
> 
>> @@ -166,7 +190,11 @@ static int omap_dm_timer_prepare(struct omap_dm_timer *timer)
>>  	__omap_dm_timer_enable_posted(timer);
>>  	omap_dm_timer_disable(timer);
>>
>> -	return omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ);
>> +	ret = omap_dm_timer_of_set_source(timer);
>> +	if (ret < 0 && ret == -ENODEV)
> 
> this < 0 check is pointless if you're going to check for equality to -ENODEV

Sure, I was certainly tired, this was a so stupid mistake...

Neil