From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754104AbbJSN3C (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Oct 2015 09:29:02 -0400
Received: from mail-pa0-f52.google.com ([209.85.220.52]:35991 "EHLO
	mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753545AbbJSN26 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Oct 2015 09:28:58 -0400
Subject: Re: [PATCH 06/14] perf/bench: List output formatting options on 'perf
 bench -h'
To: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
References: <1445241870-24854-1-git-send-email-mingo@kernel.org>
 <1445241870-24854-7-git-send-email-mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>
From: David Ahern <dsahern@gmail.com>
Message-ID: <5624F018.9040906@gmail.com>
Date: Mon, 19 Oct 2015 07:28:56 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1445241870-24854-7-git-send-email-mingo@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/19/15 2:04 AM, Ingo Molnar wrote:
> diff --git a/tools/perf/bench/mem-functions.c b/tools/perf/bench/mem-functions.c
> index 33de5d57a163..d822ee0c6003 100644
> --- a/tools/perf/bench/mem-functions.c
> +++ b/tools/perf/bench/mem-functions.c
> @@ -273,7 +273,7 @@ static double do_memcpy_gettimeofday(const struct routine *r, size_t len)
>   	return (double)(((double)len * iterations) / timeval2double(&tv_diff));
>   }
>
> -int bench_mem_memcpy(int argc, const char **argv, const char *prefix __unused)
> +int bench_mem_memcpy(int argc, const char **argv, const char *prefix __maybe_unused)
>   {
>   	struct bench_mem_info info = {
>   		.routines		= memcpy_routines,
> @@ -361,7 +361,7 @@ static const struct routine memset_routines[] = {
>   	{ NULL, }
>   };
>
> -int bench_mem_memset(int argc, const char **argv, const char *prefix __unused)
> +int bench_mem_memset(int argc, const char **argv, const char *prefix __maybe_unused)
>   {
>   	struct bench_mem_info info = {
>   		.routines		= memset_routines,
> diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c
> deleted file mode 100644
> index 7acb9b83382c..000000000000
> --- a/tools/perf/bench/mem-memcpy.c
> +++ /dev/null

All of this seems like leftovers from previous patches.