From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944AbbJSPRJ (ORCPT ); Mon, 19 Oct 2015 11:17:09 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:47227 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbbJSPRH (ORCPT ); Mon, 19 Oct 2015 11:17:07 -0400 Subject: Re: [PATCH 1/4] Documentation: tps65086: Add DT bindings for the TPS65086 PMIC To: Lee Jones References: <1445014753-15450-1-git-send-email-afd@ti.com> <1445014753-15450-2-git-send-email-afd@ti.com> <20151019091311.GH31804@x1> CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Mark Brown , Alexandre Courbot , Grygorii Strashko , , , From: "Andrew F. Davis" Message-ID: <5625095F.5080204@ti.com> Date: Mon, 19 Oct 2015 10:16:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151019091311.GH31804@x1> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/2015 04:13 AM, Lee Jones wrote: > On Fri, 16 Oct 2015, Andrew F. Davis wrote: > >> The TPS65086 PMIC contains several regulators and a GPO controller. >> Add bindings for the TPS65086 PMIC. >> >> Signed-off-by: Andrew F. Davis >> --- >> .../devicetree/bindings/gpio/gpio-tps65086.txt | 17 ++++++++ >> Documentation/devicetree/bindings/mfd/tps65086.txt | 46 ++++++++++++++++++++++ >> .../bindings/regulator/tps65086-regulator.txt | 36 +++++++++++++++++ > > Please split these up into separate patches. > > There is no functional reason to bundle them up. > ACK >> 3 files changed, 99 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-tps65086.txt >> create mode 100644 Documentation/devicetree/bindings/mfd/tps65086.txt >> create mode 100644 Documentation/devicetree/bindings/regulator/tps65086-regulator.txt > > [...] > >> diff --git a/Documentation/devicetree/bindings/mfd/tps65086.txt b/Documentation/devicetree/bindings/mfd/tps65086.txt >> new file mode 100644 >> index 0000000..4b6aeb4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/tps65086.txt >> @@ -0,0 +1,46 @@ >> +* TPS65086 Power Management Integrated Circuit bindings >> + >> +Required properties: >> + - compatible : Should be "ti,tps65086". > > Any indication that it's a PMIC? > In the compatible string? >> + - reg : Slave address. > > I2C/SPI? > ACK >> + - interrupt-parent : The parent interrupt controller. > > Phandled to ... > ACK >> + - interrupts : The interrupt line the device is connected to. >> + - interrupt-controller : Marks the device node as an interrupt controller. >> + - #interrupt-cells : The number of cells to describe an IRQ, this >> + should be 2. The first cell is the IRQ number. >> + The second cell is the flags, encoded as the trigger >> + masks from ../interrupt-controller/interrupts.txt. > > Masks? What masks? > > Best to make a link to the header where the flags are defined here. > ACK >> +Additional nodes defined in: >> + - Regulators : ../regulator/tps65086-regulator.txt. >> + - GPIO : ../gpio/gpio-tps65086.txt. > > I'd suggest removing the full stops from all of the lines above. > > Just treat them as bullet points like we normally do. > ACK >> +Example: >> + >> + pmic: tps65086@5e { >> + compatible = "ti,tps65086"; >> + reg = <0x5e>; >> + interrupt-parent = <&gpio1>; >> + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + >> + regulators { >> + compatible = "ti,tps65086-regulator"; >> + >> + buck1 { >> + regulator-name = "vcc1"; >> + regulator-min-microvolt = <1600000>; >> + regulator-max-microvolt = <1600000>; >> + regulator-boot-on; >> + ti,regulator-decay; >> + ti,regulator-step-size-25mv; >> + }; >> + }; >> + >> + gpio4: tps65086_gpio { >> + compatible = "ti,tps65086-gpio"; >> + gpio-controller; >> + #gpio-cells = <2>; >> + }; >> + }; > > [...] > -- Andrew F. Davis