From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754231AbbJSToa (ORCPT ); Mon, 19 Oct 2015 15:44:30 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43825 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752629AbbJSTo1 (ORCPT ); Mon, 19 Oct 2015 15:44:27 -0400 Subject: Re: [PATCH 4/5] drivers/tty/serial: make msm_serial.c explicitly non-modular To: Paul Gortmaker , Greg Kroah-Hartman References: <1445206878-12455-1-git-send-email-paul.gortmaker@windriver.com> <1445206878-12455-5-git-send-email-paul.gortmaker@windriver.com> Cc: linux-kernel@vger.kernel.org, Kumar Gala , Andy Gross , David Brown , Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-serial@vger.kernel.org From: Stephen Boyd Message-ID: <56254819.6030809@codeaurora.org> Date: Mon, 19 Oct 2015 12:44:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1445206878-12455-5-git-send-email-paul.gortmaker@windriver.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/2015 03:21 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/tty/serial/Kconfig:config SERIAL_MSM > drivers/tty/serial/Kconfig: bool "MSM on-chip serial port support" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We don't replace module.h with init.h since the file already has that. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Kumar Gala > Cc: Andy Gross > Cc: David Brown > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-soc@vger.kernel.org > Cc: linux-serial@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- I'd prefer we make the Kconfig a tristate. I'll test out that configuration today, but I don't see why it wouldn't work. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project