From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752182AbbJTCOS (ORCPT ); Mon, 19 Oct 2015 22:14:18 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:12690 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbbJTCOP (ORCPT ); Mon, 19 Oct 2015 22:14:15 -0400 Message-ID: <5625A33D.8070001@huawei.com> Date: Tue, 20 Oct 2015 10:13:17 +0800 From: Yunlong Song User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Namhyung Kim CC: , , , , , , , , , , Subject: Re: [PATCH v2 1/3] perf help: Add options description to 'perf -h' References: <20151014031043.GA3775@kernel.org> <1444894792-2338-1-git-send-email-yunlong.song@huawei.com> <1444894792-2338-2-git-send-email-yunlong.song@huawei.com> <20151019152925.GC14297@danjae.kornet> In-Reply-To: <20151019152925.GC14297@danjae.kornet> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.74.205] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/10/19 23:29, Namhyung Kim wrote: > Hi, > > On Thu, Oct 15, 2015 at 03:39:50PM +0800, Yunlong Song wrote: >> Add options description to 'perf -h' to make it consistent with other builtins >> (e.g., 'perf stat -h'). >> >> Example: >> >> Before this patch: >> >> # perf -h >> >> usage: perf [--version] [--help] [OPTIONS] COMMAND [ARGS] >> >> The most commonly used perf commands are: >> annotate Read perf.data (created by perf record) and display annotated code >> archive Create archive with object files with build-ids found in perf.data file >> bench General framework for benchmark suites >> buildid-cache Manage build-id cache. >> buildid-list List the buildids in a perf.data file >> >> test Runs sanity tests. >> timechart Tool to visualize total system behavior during a workload >> top System profiling tool. >> trace strace inspired tool >> probe Define new dynamic tracepoints >> >> See 'perf help COMMAND' for more information on a specific command. >> >> After this patch: >> >> # perf -h >> >> usage: perf [--version] [--help] [OPTIONS] COMMAND [ARGS] >> >> --help help >> --version version >> --exec-path exec-path >> --html-path html-path >> --paginate paginate >> --no-pager no-pager >> --perf-dir perf-dir >> --work-tree work-tree >> --debugfs-dir debugfs-dir >> --buildid-dir buildid-dir >> --list-cmds list-cmds >> --list-opts list-opts >> --debug debug > > IMHO this *help* message is not very useful in its current form. Also > please consider updating Documentation/perf.txt too. > > Thanks, > Namhyung OK, I will update the struct option of perf to a more interpretative style soon. > >> >> The most commonly used perf commands are: >> annotate Read perf.data (created by perf record) and display annotated code >> archive Create archive with object files with build-ids found in perf.data file >> bench General framework for benchmark suites >> buildid-cache Manage build-id cache. >> buildid-list List the buildids in a perf.data file >> >> test Runs sanity tests. >> timechart Tool to visualize total system behavior during a workload >> top System profiling tool. >> trace strace inspired tool >> probe Define new dynamic tracepoints >> >> See 'perf help COMMAND' for more information on a specific command. >> >> As shown above, the options description really appears now. >> >> Signed-off-by: Yunlong Song > > . > -- Thanks, Yunlong Song