From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbbJTCOK (ORCPT ); Mon, 19 Oct 2015 22:14:10 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:36672 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbbJTCOH (ORCPT ); Mon, 19 Oct 2015 22:14:07 -0400 Subject: Re: [PATCH V4 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling To: Kaixu Xia , davem@davemloft.net, acme@kernel.org, mingo@redhat.com, a.p.zijlstra@chello.nl, masami.hiramatsu.pt@hitachi.com, jolsa@kernel.org, daniel@iogearbox.net References: <1445251060-114617-1-git-send-email-xiakaixu@huawei.com> <1445251060-114617-2-git-send-email-xiakaixu@huawei.com> Cc: wangnan0@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com, hekuang@huawei.com, netdev@vger.kernel.org From: Alexei Starovoitov Message-ID: <5625A36D.8070200@plumgrid.com> Date: Mon, 19 Oct 2015 19:14:05 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445251060-114617-2-git-send-email-xiakaixu@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/15 3:37 AM, Kaixu Xia wrote: > +/* flags for PERF_EVENT_ARRAY maps*/ > +enum { > + BPF_EVENT_CTL_BIT_CUR = 0, > + BPF_EVENT_CTL_BIT_ALL = 1, > + __NR_BPF_EVENT_CTL_BITS, > +}; > + > +#define BPF_CTL_BIT_FLAG_MASK \ > + ((1ULL << __NR_BPF_EVENT_CTL_BITS) - 1) > +#define BPF_CTL_BIT_DUMP_CUR \ > + (1ULL << BPF_EVENT_CTL_BIT_CUR) > +#define BPF_CTL_BIT_DUMP_ALL \ > + (1ULL << BPF_EVENT_CTL_BIT_ALL) > + the above shouldn't be part of uapi header. It can stay in bpf_trace.c Just document these bits next to helper similar to skb_store_bytes() The rest looks ok. It still needs an ack from Peter for perf_event bits