From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751274AbbJTESN (ORCPT ); Tue, 20 Oct 2015 00:18:13 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:25477 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbbJTESM (ORCPT ); Tue, 20 Oct 2015 00:18:12 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-c1-5625c080b674 Subject: Re: [PATCH v4 6/8] drivers: soc: add support for exynos SROM driver To: Pankaj Dubey , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1445255206-11148-1-git-send-email-pankaj.dubey@samsung.com> <1445255206-11148-7-git-send-email-pankaj.dubey@samsung.com> <56258683.7070204@samsung.com> <5625B92C.10505@samsung.com> Cc: kgene.kim@samsung.com, p.fedin@samsung.com, thomas.ab@samsung.com From: Krzysztof Kozlowski Message-id: <5625C07D.4030706@samsung.com> Date: Tue, 20 Oct 2015 13:18:05 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <5625B92C.10505@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsVy+t/xa7oNB1TDDDr+GVq8fmFo0bvgKpvF psfXWC0u75rDZjHj/D4mi1eXVrFZLNr6hd2iYxmjA4fH5iX1Hn1bVjF6fN4kF8AcxWWTkpqT WZZapG+XwJUx42Q/S8FF2YrnH24xNTBeE+9i5OSQEDCRuLX9IhOELSZx4d56ti5GLg4hgaWM Eh8OfGCGcL4wStxYvYgZpEpYwEfi7JoPLCAJEYEpjBIXe5YxQlQdZZQ49Wof2CxmAVeJ7c/a wDrYBIwlNi9fwgZi8wpoSVz6OI0dxGYRUJXY9P8CC4gtKhAhMXFCAytEjaDEj8n3wOKcApoS G94cBOrlAJqpJ3H/ohbEeHmJzWveMk9gFJiFpGMWQtUsJFULGJlXMYqmliYXFCel5xrqFSfm Fpfmpesl5+duYoSE9ZcdjIuPWR1iFOBgVOLh1YhRDRNiTSwrrsw9xCjBwawkwqvRAxTiTUms rEotyo8vKs1JLT7EKM3BoiTOO3fX+xAhgfTEktTs1NSC1CKYLBMHp1QDY8B3k5p2VbN13mpr tMMWH8nSjw3vUHZREez44pF+PPlrQ8GDxX8/51sW5mbM2yb57M1UQ74oSUH7/wVzOFl8s1qU ZgjmHZlembTlnPrCn46eOWyHXgrMjkuZPFH+TUtrJm8tL8/yW6o/ClZcMhQsUy9UL998+fXh aS7sAfMf9Pa+ulZr1vFRiaU4I9FQi7moOBEAB2dbmWcCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.10.2015 12:46, Pankaj Dubey wrote: > Hi Krzysztof, > > On Tuesday 20 October 2015 05:40 AM, Krzysztof Kozlowski wrote: >> On 19.10.2015 20:46, Pankaj Dubey wrote: >>> This patch adds Exynos SROM controller driver which will handle >>> save restore of SROM registers during S2R. >>> >>> Signed-off-by: Pankaj Dubey >>> --- >>> drivers/soc/Kconfig | 1 + >>> drivers/soc/Makefile | 1 + >>> drivers/soc/samsung/Kconfig | 13 +++ >>> drivers/soc/samsung/Makefile | 1 + >>> drivers/soc/samsung/exynos-srom.c | 179 >>> ++++++++++++++++++++++++++++++++++++++ >>> drivers/soc/samsung/exynos-srom.h | 51 +++++++++++ >>> 6 files changed, 246 insertions(+) >>> create mode 100644 drivers/soc/samsung/Kconfig >>> create mode 100644 drivers/soc/samsung/Makefile >>> create mode 100644 drivers/soc/samsung/exynos-srom.c >>> create mode 100644 drivers/soc/samsung/exynos-srom.h >>> >>> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig >>> index 96ddecb..69107c9 100644 >>> --- a/drivers/soc/Kconfig >>> +++ b/drivers/soc/Kconfig >>> @@ -2,6 +2,7 @@ menu "SOC (System On Chip) specific Drivers" >>> >>> source "drivers/soc/mediatek/Kconfig" >>> source "drivers/soc/qcom/Kconfig" >>> +source "drivers/soc/samsung/Kconfig" >>> source "drivers/soc/sunxi/Kconfig" >>> source "drivers/soc/ti/Kconfig" >>> source "drivers/soc/versatile/Kconfig" >>> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile >>> index 0b12d77..a623616 100644 >>> --- a/drivers/soc/Makefile >>> +++ b/drivers/soc/Makefile >>> @@ -5,6 +5,7 @@ >>> obj-$(CONFIG_MACH_DOVE) += dove/ >>> obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/ >>> obj-$(CONFIG_ARCH_QCOM) += qcom/ >>> +obj-$(CONFIG_SOC_SAMSUNG) += samsung/ >>> obj-$(CONFIG_ARCH_SUNXI) += sunxi/ >>> obj-$(CONFIG_ARCH_TEGRA) += tegra/ >>> obj-$(CONFIG_SOC_TI) += ti/ >>> diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig >>> new file mode 100644 >>> index 0000000..ea4bc2a >>> --- /dev/null >>> +++ b/drivers/soc/samsung/Kconfig >>> @@ -0,0 +1,13 @@ >>> +# >>> +# SAMSUNG SoC drivers >>> +# >>> +menu "Samsung SOC driver support" >>> + >>> +config SOC_SAMSUNG >>> + bool >>> + >>> +config EXYNOS_SROM >>> + bool >>> + depends on ARM && ARCH_EXYNOS >> >> When !PM then the driver will... do nothing, right? So maybe make it >> depending on PM so tiny configs would benefit? >> > > Yes. Currently driver will do nothing if !PM. But as we know Fedin, has > a plan to extend this driver for auxiliary H/W IP hooked to SROM. So in > that case this dependency will not be valid as those functionality may > not be dependent on PM, and we may need to remove it later. So I feel > better not to add it at first place itself. AFAIR Fedin was talking about missing functionality, not about adding the contribution by himself. So he might add it or he might not. I did not receive any commitments from him. The driver should be "proper" for the time being (which could mean !PM dependency). If there is a need, then the dependency will be removed. > >>> +static int exynos_srom_remove(struct platform_device *pdev) >>> +{ >>> + struct exynos_srom *srom = platform_get_drvdata(pdev); >>> + >>> + kfree(srom->reg_offset); >>> + iounmap(srom->reg_base); >>> + srom->reg_base = NULL; >>> + srom->reg_offset = NULL; >> >> There is no need anymore for these two NULL-s. It made sense only in >> previous code when these were global variables. At this point the device >> callbacks cannot be accessed so NULL-ifying does not change anything. >> > > Agreed. Will update. > Thanks, Krzysztof