From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753990AbbJTIVY (ORCPT ); Tue, 20 Oct 2015 04:21:24 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:43051 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753958AbbJTIVS (ORCPT ); Tue, 20 Oct 2015 04:21:18 -0400 X-AuditID: cbfee68d-f79ae6d00000149a-e8-5625f97c39f6 Message-id: <5625F97B.50605@samsung.com> Date: Tue, 20 Oct 2015 13:51:15 +0530 From: Pankaj Dubey User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Pavel Fedin , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kgene.kim@samsung.com, thomas.ab@samsung.com Subject: Re: [PATCH v4 6/8] drivers: soc: add support for exynos SROM driver References: <1445255206-11148-1-git-send-email-pankaj.dubey@samsung.com> <1445255206-11148-7-git-send-email-pankaj.dubey@samsung.com> <56258683.7070204@samsung.com> <5625B92C.10505@samsung.com> <5625C07D.4030706@samsung.com> <014301d10b01$488873f0$d9995bd0$@samsung.com> <5625E3B9.8040707@samsung.com> In-reply-to: <5625E3B9.8040707@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsWyRsSkVrfmp2qYwYHpkhavXxha9C64ymax 6fE1VovLu+awWcw4v4/J4tWlVWwWHcsYHdg9Ni+p9+jbsorR4/MmuQDmKC6blNSczLLUIn27 BK6MS4/esRRc4ajYs/MqawPjK7YuRk4OCQETiUunzkLZYhIX7q0Hsrk4hARWMEqcv/GJHabo YnsDC0RiKaPE5N5tUFXfGSW6H2xm7mLk4OAV0JDYv0IXpIFFQFVibudaVhCbTUBX4sn7ucwg tqhAhMTbyyeZQGxeAUGJH5PvgQ0VEdjPKHHjyyqwM5gFDCR+3GwAKxIW8JE4u+YD1OatTBKT F2wBm8QpoC0xc8dkqAZbiQXv17FA2PISm9e8ZQZpkBDYxy7x7/hbdoiTBCS+TT7EAnKphICs xKYDzBCvSUocXHGDZQKj2CwkR81CMnYWkrELGJlXMYqmFiQXFCelFxnqFSfmFpfmpesl5+du YgRG2Ol/z3p3MN4+YH2IUYCDUYmHVyNGNUyINbGsuDL3EKMp0BUTmaVEk/OBcZxXEm9obGZk YWpiamxkbmmmJM6rKPUzWEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAPjvan+k5Jk+DKWTHmg 6LvSr+rAtuV3/BKeev7xK9o9vW3tkpY9jzfMVd//8O2tH5GtbBeZ3u+f9TKZf0rv1XOTZm9o +yjx7sW5t17Fh1M7Knisd2lrKbFE9+afi5t3aPHd/zdzA8NNemrCyjvUb+pw7nYMKHpWvWHJ h52fzr1O33y66EC6g9oNSyWW4oxEQy3mouJEAH8emXGrAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsVy+t9jAd2an6phBo/2C1m8fmFo0bvgKpvF psfXWC0u75rDZjHj/D4mi1eXVrFZdCxjdGD32Lyk3qNvyypGj8+b5AKYoxoYbTJSE1NSixRS 85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOAVisplCXmlAKFAhKLi5X0 7TBNCA1x07WAaYzQ9Q0JgusxMkADCWsYMy49esdScIWjYs/Oq6wNjK/Yuhg5OSQETCQutjew QNhiEhfurQeKc3EICSxllJjcuw3K+c4o0f1gM3MXIwcHr4CGxP4VuiANLAKqEnM717KC2GwC uhJP3s9lBrFFBSIk3l4+yQRi8woISvyYfI8FZI6IwH5GiRtfVoFtZhYwkPhxswGsSFjAR+Ls mg8sEMu2MklMXrAFbBKngLbEzB2ToRpsJRa8X8cCYctLbF7zlnkCo8AsJEtmISmbhaRsASPz KkaJ1ILkguKk9FyjvNRyveLE3OLSvHS95PzcTYzgKH4mvYPx8C73Q4wCHIxKPLyaMaphQqyJ ZcWVuYcYJTiYlUR4n50ACvGmJFZWpRblxxeV5qQWH2I0BQbDRGYp0eR8YILJK4k3NDYxNzU2 tTSxMDGzVBLnvXGIIUxIID2xJDU7NbUgtQimj4mDU6qBsaMr+1GPIaePwu9dLNcYOUqOZ7dG Orr9ttpYsOrHtP8/j07r2Xx6R/lZ86kvnnvs381+b/Puz9axUeVsr19mfZDJPJR9htkvrE/7 jtO73fkGLWVyBzb3xh/7nmh+5+4jr+hJ05Ys4MxcqX46+bvDrBkCJf7FZ2ft1DHMmBL1ZPon 7mDuCM+rW5VYijMSDbWYi4oTARxhLKr4AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 20 October 2015 12:18 PM, Krzysztof Kozlowski wrote: > On 20.10.2015 15:33, Pavel Fedin wrote: >> Hello! >> >>> AFAIR Fedin was talking about missing functionality, not about adding >>> the contribution by himself. So he might add it or he might not. I did >>> not receive any commitments from him. >> >> I am waiting for the driver to be integrated, because i see it's constantly redesigned. Then i'll post my patches. > > That means you will extend the driver? Great! So from my point of view > it is fine. > > Dear Pankaj, > > With the fix of unneeded NULL assignments: > > Reviewed-by: Krzysztof Kozlowski > Thanks. Will update v5 soon with suggested modification. Thanks, Pankaj Dubey > >> By the way, they >> will be useful only if pin controller driver for 5410 is accepted upstream, several authors have done it but i still didn't see it >> in upstream. >> Pin controller is needed in order to configure multi-functional pins correctly. > > Are there any obstacles for upstreaming it? > > Best regards, > Krzysztof > >