From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484AbbJTLRM (ORCPT ); Tue, 20 Oct 2015 07:17:12 -0400 Received: from mail-bl2on0083.outbound.protection.outlook.com ([65.55.169.83]:41937 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751666AbbJTLRG (ORCPT ); Tue, 20 Oct 2015 07:17:06 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform. To: Josh Cartwright , Michal Simek References: <1445035350-3569-1-git-send-email-moritz.fischer@ettus.com> <1445035350-3569-3-git-send-email-moritz.fischer@ettus.com> <20151018175324.GH12756@jcartwri.amer.corp.natinst.com> <5624F985.8050905@xilinx.com> <20151019182416.GL12756@jcartwri.amer.corp.natinst.com> CC: Moritz Fischer , , , , , , , , , , , , From: Michal Simek Message-ID: <5626223F.6040008@xilinx.com> Date: Tue, 20 Oct 2015 13:15:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151019182416.GL12756@jcartwri.amer.corp.natinst.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21890.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD004;1:eQGzK2TqnWFoWJvw3Jrv4bMRA2f5eKM0uPtPyEr52gnO6Hp3ub6Ev3syee6g/8czk7eh65UtDt2kW/+/7qCjjsFFFNb3nctV3mGH4edHKOWw8TdLQ/9ReO49BGx+zSHYFXeo/WyI5gVc2mdw/CdJPbichDDYgikmobQkww/xpuJT/1w+yeuz6PAJd29vjIHoxvP7Im5P/xYBLLY4LwCtWpgl09z/Z8qVpWvPIOEZzR6BqFNqUBvaof6jVzlKV4I67AC19T88rCaWgHU95xrit4lE3an7ji6ka3q0a9OBsZXDroy9EAL1VGt8BRcrQRacaqqpVb9Yb2pj2ucvlCD3qGOflTSdqqZcojdRDxpnonZJQCSpq2tsUBSgFS+LC9Or X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(164054003)(189002)(24454002)(479174004)(199003)(377454003)(99136001)(86362001)(4001350100001)(65956001)(23746002)(47776003)(65806001)(81156007)(5001770100001)(46102003)(64706001)(64126003)(5007970100001)(11100500001)(83506001)(4001450100002)(6806005)(36756003)(106466001)(93886004)(80316001)(5001960100002)(19580405001)(36386004)(87936001)(87266999)(59896002)(77096005)(63266004)(50986999)(76176999)(5008740100001)(54356999)(2950100001)(65816999)(50466002)(33656002)(189998001)(92566002)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1BFFO11HUB030;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB030;2:HymPT7LHMyWVHo13KDezKKvTy5IjVVSY+HS82mzWgTTWt/mSHTdvdQjORyw7gipf6VuQTYUhYu2KZc19fi6VE5g9JZRcPm3YR+d0HKQ316MFFgxpUwmBPXtab7v+zhgLat5pq2ZduSC9rZtX40xXErx+5PURk72rGSzQ9R+0T5s=;3:yE3tV3dDpnnh5npDWgYOpqVKZOwVxMqY7zBKvHZxMP5ooqbwoQ2Dujz0RhAGdX65ar9Kg3kQJo3dJVZr/YgDfhWWf9t2S4QJ1s8rdgheE8TueIEmk6F1namt/yZEWe6s92orh2K8E/FpmYsyA8h0eUG95UFXaYIBiMtRp9d+Vvvrn7NWV6KxdfJpP++FMcaDg1cZq7Hu+zliYTxWekcGvgqmLOMIHzBZeJoAHKp2FxDNLV1o+5gricjBkT9wnq8WVAkXr0/rVMSx7Ytex0CYNQ==;25:WSHdgU3NVCQhJRd8jzCABqiJfAFXdPku/0SzYCokB02wbZOUaJ1xbv/ZX9YxXLk3KotWnhG0CoFcNV4cqoUbgc3sNm8/Q5bTuPf6XBduVvesmHFv3AyAWnPddIeEmHp38gA99pOYaaNp4djRc8wlg/oWUp0BdrQ7AZQIOQfqRDTy1CVTnxw/A+nutxr0jbKUtTjcO2Mlre4pTmJETrnJiS+TTp8GQmIbEn6JtnhwMaVBvoAbbO+MBTAIDuQA4ETWVvSLz5Ao9bimgdPecLDZ/g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN1BFFO11HUB030; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB030;20:WunTxt8sxesGWH5fJzxZQdFfIY06w5MR+epv652fXhO6jrBcREwaMxnXAfIVsZi0NRrhgjCcpXll61bfSegbub4SM2yYIsOA2RLz2eeBeVPwKp38YFrxIMAJwkMMLHneegrRAF/WXRIDACBjfYhW7MNat9y0dLkrZ1c4BUZ7CmgfNq0BSRb3zEBjO+SOWfs/i8PI9SswZnWUXDoeUkwKXpgeZo2q3D8rDmma9JUKZMf2aRHswy8gXzsXn+cG09p5aO8bHx/AkLjdQap5eR4r5ODEYD0zSHfnGg8Hqw6Gc5vli9vwvXdC6S7eYpVUCncHuoOTxMj4lunFhAL414epyMYfxNL54jaPG6Jw1DFSDJxSj+rxpKAyRZwG6aIqYQTUX808mw5RrqlhgcefRlXQhoEA0Sm4Wb8vG92Xr44pGO3XAQVtWTemgWcMzCFZwB0hfo9ZTf1/5jWuAYTV5IxPK0tbcZS/k59faDDeF9XuHpARr1x/Lpra9y6fVA0FcvV+;4:uKKGqWtFW0qU2KDXC3dNZ1di86TLqm+5Ab7PSfx5FIYGzmUgPMzA1fQ+ZheE2cUn7cqGOlmnCsmR80jEIEj75jHmoxzn/Da7A0LQR6kTln7ZD3nRwfZ47rrus/pp+rOlOUpmJt+jTstOk7V+CmoVt2IfN9i/d0WGpxdbFg+dH+sSfk0HPGHrvPidDGFdsxorjbwLCRlKGKiw3GUsMymIGP0VeglHlzZ0oiyixnWWtn7Da9wD6GMLKWTXmbb/cO0ERuqre9qYwKwZU2abV1F2VnMn07NePGg+/1Kzz4tftMTIajMROVtO//2CirqoItoomRH5Zzjv18jLNdnZ1egCL3/LDKLc8MX3wWFoaN4xdob0l08bkTnRcWtm7KcHpXrH X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(10115024);SRVR:BN1BFFO11HUB030;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB030; X-Forefront-PRVS: 073515755F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN1BFFO11HUB030;23:4efxOOsZjiH4Xhe3RDgN4LdbGE9j65ESSW1?= =?Windows-1252?Q?/c2KHMcxrTZ6Yk+/nwxqq5puaiGWZu08/Ob9NOcqcDFImmB7QxcxUbGX?= =?Windows-1252?Q?biXYf8ePyLDk3n56T2zyfhzWkawEtaC5n5Yt8IrxqzWrvs2jVfjJajqA?= =?Windows-1252?Q?n+tpeQDXnrT0MaY/0vlehcRsuXZMgGRSBzpLy2/eWX/RXIhi6Y7147OQ?= =?Windows-1252?Q?CyRjb6w7Ov8lbREdo2mFuCmWpH37OHADXJlz8xhRpTvqC9ykisRlM9Db?= =?Windows-1252?Q?WVAycKhdb7LWg3aCldBPAxDCMxYhByb4F4ya3bE0aWk1M50GAzl7C9P8?= =?Windows-1252?Q?UhnLpg46Xs4aiWb3MrS94MUwMNJxrvouXO9tRxqMyR5buSiHrOR3rDdp?= =?Windows-1252?Q?KP9gjL7iRrcZ/Nds3m0ziocEgZnUiO1vCCDvBWgU3HArLUVytSHFu+Kf?= =?Windows-1252?Q?X1sqm8rl2dEMDLqUtbpdxxCJg7uP1ApRV5D/K7PpMXrzrhxfWQxpba83?= =?Windows-1252?Q?Nc66eg6BEIgJs9amKjRHQpz9qREqq5sOMz3QbOaujcvahDJp06NrzAos?= =?Windows-1252?Q?KD6A81jADyUnt3IX2/m5ioyCT3eX5GjLB8BzeFKlq15THOiw7KTMcTlL?= =?Windows-1252?Q?rbdy2gcPhgC7vhSqzhqPTmtdoyxAP3bZUfPhxo1+3M5CinhqgB0TTFU3?= =?Windows-1252?Q?EsIax+n96rOo+ka8Su/m2DuQIaBlZBa0Q4ZnTsZ5ZqJQGbmtSg/niuy+?= =?Windows-1252?Q?6c0oIimt8GhJH8jx9ckQium451yFAVZ/Gj1fbMmaeIeUUs08b6ES7DQR?= =?Windows-1252?Q?VBT7jiKPQM8gitB66hmTc5sbAQQeXssvk1tP03ba4vCgibLUrXj5LKGk?= =?Windows-1252?Q?JGkd8S9ruu1AJGyTR+EtqmGQ2wCF15v/WLgfTf/k8DVfl0KpJfct3aZ5?= =?Windows-1252?Q?LeNogbNu4jVO5vWWd0k/u5NiNgpa6zG5QuR/KS1ey9usjTFYJpksGsmA?= =?Windows-1252?Q?ZqmnC+VrThZf/OduZ07dNzJMvPewtKb7VtXouMO70GeEj4qqZMJnTeU7?= =?Windows-1252?Q?4jKyxA+kZxAoxCHbO7iMiep/TewN7KBxGAmWRYH/SB42mLA93rm0PjD/?= =?Windows-1252?Q?ge8f7eVQifkGv6RDtDZP/ygQoW0J3SQd6W0x0YVIaUFCbVT39rFOpugQ?= =?Windows-1252?Q?4x0gHTUod2BlslI0KpUye1XgHGW0ToSRwqmDwzSRMNH/0eCpZcvCMeKk?= =?Windows-1252?Q?jbbk2Hq+bKZkVUVERAE0bhoaorFMaRmnI4FIjxCPFVNQqsMXnc5PdxZh?= =?Windows-1252?Q?Kc9WuJbaFWW3VRcrqyXBzJdJzwphjDzis6zh7qfjlx0QdR6je1+JEuBo?= =?Windows-1252?Q?OcRzGTBXLcQrZsO2iFUbBIGKA3SyuhAklmw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB030;5:XrBs0lsPaRFrOy9rfvDnz/oUPV8d7nrZHvaZK/J9O7aEN2xw9tdsPSSUVqSjQXKVSJd9lv5yu4VN5R7EfKAjRazRwoTJjPoBP4+Vr+SRZYWT0dvJhT8uJuw3Ua9bC+WmegFyAuzZNM8c5+6zM7Ol7Q==;24:nn7S4JLk+ExHssrVrcZHH3vuRYaViN0eMNPxPpPw5iC7wfQ7uX610RqhOneq6z1vKaAOwzgDAdvI9BxKiqfd5WnX1fFAZdjPtnJ1hXgsm/0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2015 11:17:04.0159 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB030 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/2015 08:24 PM, Josh Cartwright wrote: > On Mon, Oct 19, 2015 at 04:09:09PM +0200, Michal Simek wrote: >> On 10/18/2015 07:53 PM, Josh Cartwright wrote: >>> On Fri, Oct 16, 2015 at 03:42:29PM -0700, Moritz Fischer wrote: > [..] >>>> @@ -294,6 +294,11 @@ >>>> devcfg: devcfg@f8007000 { >>>> compatible = "xlnx,zynq-devcfg-1.0"; >>>> reg = <0xf8007000 0x100>; >>>> + interrupt-parent = <&intc>; >>> >>> You shouldn't need interrupt-parent here. In fact, I suspect it can be >>> removed from all sibling nodes as well. >> >> Correct. But I tend to do it vice-versa. To remove it from amba node and >> keep it in every IP here. The reason is simple to let everybody know >> that setting up right interrupt controller is something what they have >> to care. If you have more interrupt controllers in the system it can be >> messy. > > If you like that, then you'd like the interrupt-extended properly even > better (I think). yep. That works for me too. Thanks, Michal