From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Luis de Bethencourt <luisbg@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: nab@linux-iscsi.org, cvubrugier@fastmail.fm, sagig@mellanox.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc()
Date: Tue, 20 Oct 2015 14:41:38 +0300 [thread overview]
Message-ID: <56262872.1030302@dev.mellanox.co.il> (raw)
In-Reply-To: <1445285904-31247-1-git-send-email-luisbg@osg.samsung.com>
On 10/19/2015 11:18 PM, Luis de Bethencourt wrote:
> Smatch complains about returning hard coded error codes, silence this
> warning.
>
> drivers/target/iscsi/iscsi_target_parameters.c:211 iscsi_create_default_params() warn: returning -1 instead of -ENOMEM is sloppy
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Looks good,
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
next prev parent reply other threads:[~2015-10-20 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 20:18 [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc() Luis de Bethencourt
2015-10-20 11:41 ` Sagi Grimberg [this message]
2015-11-14 22:31 ` Nicholas A. Bellinger
2015-11-15 1:11 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56262872.1030302@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=cvubrugier@fastmail.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox