From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbbJTLlr (ORCPT ); Tue, 20 Oct 2015 07:41:47 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:34147 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbbJTLln (ORCPT ); Tue, 20 Oct 2015 07:41:43 -0400 Subject: Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc() To: Luis de Bethencourt , linux-kernel@vger.kernel.org References: <1445285904-31247-1-git-send-email-luisbg@osg.samsung.com> Cc: nab@linux-iscsi.org, cvubrugier@fastmail.fm, sagig@mellanox.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org From: Sagi Grimberg Message-ID: <56262872.1030302@dev.mellanox.co.il> Date: Tue, 20 Oct 2015 14:41:38 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445285904-31247-1-git-send-email-luisbg@osg.samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/2015 11:18 PM, Luis de Bethencourt wrote: > Smatch complains about returning hard coded error codes, silence this > warning. > > drivers/target/iscsi/iscsi_target_parameters.c:211 iscsi_create_default_params() warn: returning -1 instead of -ENOMEM is sloppy > > Signed-off-by: Luis de Bethencourt Looks good, Reviewed-by: Sagi Grimberg