From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752611AbbJTPta (ORCPT ); Tue, 20 Oct 2015 11:49:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55343 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbbJTPt1 (ORCPT ); Tue, 20 Oct 2015 11:49:27 -0400 Subject: Re: [PATCH] tools lib traceevent: update KVM plugin To: Steven Rostedt References: <1443695293-31127-1-git-send-email-pbonzini@redhat.com> <56181F25.2070402@redhat.com> <20151020143244.GG4400@redhat.com> <20151020104459.7e7f7e77@gandalf.local.home> <56265B70.1000206@redhat.com> <20151020112648.4d323069@gandalf.local.home> <56265FC7.9050409@redhat.com> <20151020114811.772dff41@gandalf.local.home> Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, acme@kernel.org From: Paolo Bonzini Message-ID: <56266282.3040109@redhat.com> Date: Tue, 20 Oct 2015 17:49:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151020114811.772dff41@gandalf.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/10/2015 17:48, Steven Rostedt wrote: > On Tue, 20 Oct 2015 17:37:43 +0200 > Paolo Bonzini wrote: > >> However, it frankly seems a bit academic. The parsing _will_ work, >> apart from printing a nonsensical role just like it has always done for >> the past four years. > > I'm not going to be too picky about it. But things like this may seem > academic, but it's also what we forget about, and people still use > 2.6.32 kernels, and this may come back and bite us later. > > But it's more likely to bite you than me, so if you don't think it's > worth while, then I'm not going to push it. Thanks. The role is not going to matter except in really weird cases and hopefully those are just not there in 2.6.32 kernels. Thanks also for educating me so I won't get it wrong in the future! Paolo