From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbbJTRil (ORCPT ); Tue, 20 Oct 2015 13:38:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41949 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbbJTRik (ORCPT ); Tue, 20 Oct 2015 13:38:40 -0400 Subject: Re: [PATCH] IB/ucma: check workqueue allocation before usage To: Sasha Levin , Jason Gunthorpe , Yishai Hadas References: <1442520259-2248-1-git-send-email-sasha.levin@oracle.com> <20150917225934.GA22326@obsidianresearch.com> <560D491F.7020200@oracle.com> Cc: sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org From: Doug Ledford Openpgp: id=AE6B1BDA122B23B4265B1274B826A3330E572FDD; url=pgp.mit.edu Organization: Red Hat, Inc. Message-ID: <56267C1E.4040701@redhat.com> Date: Tue, 20 Oct 2015 13:38:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <560D491F.7020200@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DLIePnULmk972BLsQCQ7SFqwMLfmmhudN" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DLIePnULmk972BLsQCQ7SFqwMLfmmhudN Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/01/2015 10:54 AM, Sasha Levin wrote: > On 09/17/2015 06:59 PM, Jason Gunthorpe wrote: >> On Thu, Sep 17, 2015 at 04:04:19PM -0400, Sasha Levin wrote: >>> Allocating a workqueue might fail, which wasn't checked so far and wo= uld >>> lead to NULL ptr derefs when an attempt to use it was made. >> >> Indeed. >> >> Yishai, please check this and check the other patches you've sent to >> see if they have a similar error. >=20 > Ping? It doesn't seem that the patch got anywhere. Sorry, I took the "it applies to linux-next" to mean it wasn't against my tree yet and was against upcoming patches. That wasn't the case. It's been applied. --=20 Doug Ledford GPG KeyID: 0E572FDD --DLIePnULmk972BLsQCQ7SFqwMLfmmhudN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJWJnweAAoJELgmozMOVy/dkTQP/Ri62QQ9Jpm9WlUi8g6zgvlt WgfYh+l83uaKa5HgPRwLj7iP4MaXOvOKI/zSZyAYxIQ2VRqigR0DpZ8tQ9RCGI1m Vf1DzvR3e4o1xvcecyl36weKuYdsXSJFzbgSMp/aQZtiMFdQ/yuoKAh/sIoCYCNH zbSf+1QJTWYL+i6zZSdVXE3eU3ptZhRtMZC37ZoBmRTf2B3rXA9Y2JcWPsV3kaiQ K2Oj40K91/EdkwA/zK/1C1EnHSxDvBRe7zyjI1tTJkfwUI9OWpNcAOGRjelEIWyG r09ROChgwYCvLIXnOzCaELpHBluQaWS8TfbnZnm8mb6sapGLXIjaXryVhEM13iXv jhDhYN/QHi8pet/Mg0U0f0r+DqD6bcnb5uZdZIdX5N/nRJNxmwaDOSbyDueahjOq f+HTzrI8X4LfRSyi8yIsL2scb/e583bs7M1H6tg68R2xm++q02fIht49HLyD/Lqe O661yOun/NGQhac2rA1agqLM8iX71+K4+kIwqHlX6c5pZjKJ8uiLVUrHFltem5wQ rhLC0sVRMO8JV/sVq/prjuBEGVEM+5rhgILyZ5qaT2ZvHilvzT3nHSCKfbUmT3yU w6hCyt142SQWB8YvsgFfECQu8YL9jmPBbDF+eFUo/nitIPvMh1jWU12LWCgb5G8a +TeiWGbK+5fnSK68CIp/ =jBdV -----END PGP SIGNATURE----- --DLIePnULmk972BLsQCQ7SFqwMLfmmhudN--