From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbbJTTbx (ORCPT ); Tue, 20 Oct 2015 15:31:53 -0400 Received: from mail-by2on0095.outbound.protection.outlook.com ([207.46.100.95]:8607 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751107AbbJTTbs (ORCPT ); Tue, 20 Oct 2015 15:31:48 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NWJ9KE-08-426-02 X-M-MSG: Subject: Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC To: Mark Rutland , Borislav Petkov References: <1445282597-18999-1-git-send-email-brijeshkumar.singh@amd.com> <20151019205236.GB453@leverpostej> <56266F7E.6030404@amd.com> <20151020165744.GE31130@pd.tnic> <20151020172654.GC4943@leverpostej> <20151020173639.GH31130@pd.tnic> <20151020174144.GD4943@leverpostej> CC: , Arnd Bergmann , , , , , , , , , , From: Brijesh Singh Message-ID: <562692F1.1030209@amd.com> Date: Tue, 20 Oct 2015 14:16:01 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151020174144.GD4943@leverpostej> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(2980300002)(428002)(24454002)(479174004)(377454003)(164054003)(189002)(199003)(50466002)(11100500001)(23746002)(105586002)(80316001)(64126003)(101416001)(65816999)(87266999)(54356999)(5004730100002)(106466001)(5008740100001)(50986999)(46102003)(59896002)(76176999)(92566002)(189998001)(65956001)(5007970100001)(65806001)(47776003)(86362001)(33656002)(4001350100001)(97736004)(5001770100001)(77096005)(2950100001)(99136001)(64706001)(93886004)(87936001)(83506001)(36756003)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0709;H:atltwp02.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;2:AWADQOxnan0BIlln4axip7glhQ2/SqcBEiwX5TxHsRgVI05MpwSuuOLWaunytPJ9jAPDHc7p/H6ZBPT/vJ3qXMNAXQWFE6eyE0GfJ4iyKs8ULX3NYLsZ4iJzmOXVG24GqljtQgzPlr5TJc/M6EHupunkc5nPoQWOt8FjABgAQak=;3:QfllkhxccTNSrroBi3eSLTOrJUmGu+yEuK95V9tx6GtL9Qc1AjkAXwG6i6+cd/qP8U3VUeDEC5w7F2tG8RoIStM8ZMaHZY40lQ2NN3+/pPyTZn+y96+AQG6yoEzDxTDP8WxB1JoDYd0dz97RgMQ/evkO636FyCjNc+ihaaKqcM0poqg5FtZR+DA6Popf3WoY09FtMUA5d551xsEfXnXMbC8SLjBTd5UzVYJp+4ToVwTHtDt0zHctdEDkwGKKYogl;25:iUI25PIFrfZIV3oVpyj4flmeArJYiQ3kfDn7jca+dj9JaIGC9zbGkRbkp/jtDpEuvR0d8g85e7pJxDouJQHp4fcsPnM2aHhIKaH2Nhr43aCRZqR3LWrslBGZXOUDiYSd/l1JZuGztcKNTVerFSRGbi3bnPGQ6gnYCQyDrj3KF4g0tV+tkOlf7iyFcFEY7919/hDVC/1oGau6XN/s7lZXZPeHKDpkLbIsVl0YLGmYvaBVeqwCwKPGbt56TP2EIKn4Hz23zl9DL7wN8zJKFsY38Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0709; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;20:Us99aDpI14a3m2KNax1KW7+pxf2FQcYwOiXQw09N8Is9pwS++9eLdScv3TFPncWlB4dZVAK9UmuqatMfqTyMO/gZm2ikPsu9BX4Gjyz6glss72OeNjSs6QW7Jf3pXyO5LqHhRRAC8SDxCFCMZbboafYj1fhqmkkAac0iB51bUCSGrKmLyYI34YwBAot2g4tL5ZkVKSucxD7s2wNq8wrdfBFPyCmXdvQrCGaw0Lo0LbUMnLZ9Ux9MNrs1vFIXbbW88gixn7lToYR5QNfz9ZR/UFwWM56a6cW6bEtddf1/WDnMohmFVmKkfIjXXsLLMlz1Bn4VKF+/6dbj/mLplpNqSGlN49bXYwUlRt3AhBX/dDsydPWfvoVMNnVk0cL1usxXfjoD+FZla0rSNGeVAwGQ9l1C3zFXmt0sIm85Qxb2PnUbwi1TVTayG+cgg0/3suYlqRxH+Jc1jAgeJj6goU9a+e5WbrQBhoy4asJ4CK3DsOo8OgPfu821Dklh0YbJ2Ljm;4:FE9YHhGzhES5QdmrGBb2eI2FlmR/V+W/XebiI8+MV/2hlQl8+vGd4XbPB4rk18F0os7evb2mcs53cQ7iiP4E//WhTeP22dPRG91kue2trczhXLqosFLGyxFw+zIEwTsnnD86sxCvkT/SDEsHqGU/CW5ctU0YkXqGrflx5OZ3f2yX2n0pI5wS/RQ9ViosY1rHbElL70ewKFNuK2LqrUg+l5f9lNysBs4eACk3wdpLFwafqnGXdeRzGDv2JJIHSuPyQrNWoBDJw/wZfqzCJ9RLcOPUnLL0djVBZJCnjk+qDOBDJM7DwZGwcs/yUDd6OyKjldNcUAP3vq4lJ07jdvmtzkGP33/jODEpvB0A7AdVMIc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:BY2PR12MB0709;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0709; X-Forefront-PRVS: 073515755F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR12MB0709;23:wnfl/W8B65SY2f7xatxqtuX4XN13EaVfhzfPs?= =?Windows-1252?Q?SgfurqETqBltKeuf37dIqXRbgUIz1OufxKOzJQph1m22gXCI4go+jDNm?= =?Windows-1252?Q?77I/5KV4o8tKXZ7SdefA3DlRNMWmamdH0fak7VwNr9hAtqEkIDwyUVU7?= =?Windows-1252?Q?7FKtUCo4ZFw5YwS9j8TbPGDJ/tEzslXi1/EmbOgCXI9LNLPs7mIQ3I+Y?= =?Windows-1252?Q?Z82MIeGvslT5RA9M2zOP87hwtl6Lh0ZsUv2Y9H0Kd+rXPLbFOcKG24mp?= =?Windows-1252?Q?r+/oc7Y3mcEHQASV0qok5I9z96aOSGmRRThCSa2KDPzli4SQuxHehviL?= =?Windows-1252?Q?1lNRmA6gWPKcuhMl/OjTwsMEOlIaaxBM9nHIyDSebgaVK3DK5p+Aupob?= =?Windows-1252?Q?hH+4hcVwEiP5MjyY1d7CCTLwYK6j1HWAQsk2LFqdl6YMaxJmCf3rDfn7?= =?Windows-1252?Q?5ukGG6cJC4/1EvnfJwS9UoYkGyoeo1ZqMcBTBq8dQNdqKByDiea5IDkJ?= =?Windows-1252?Q?zxZYI4QjTBYwxN4vWNkH3QfLGwP15bOtOKrhAIcnkr8g6aFrmzNdOD98?= =?Windows-1252?Q?ReZUCVh7xwoDa7OHSiaMk8xkF2yFZf7tWiLimN6s28uTZvZDWJf6Def1?= =?Windows-1252?Q?e4lqFV63hH8UdArgkMzdpjA3yPGI2tCBLUGgtHFFd21J9LZhBgZoswZ5?= =?Windows-1252?Q?rVFncYZLmA0hW3NUeSFrobDQsZGkGOWk25kWng0ZgoEEvKNj33QoHeBW?= =?Windows-1252?Q?XyodWS465YVKjVtlebZDl3+X/qR34uLRgLZp13RZw4OEaUZgQNkmxw4I?= =?Windows-1252?Q?KE96C6ZnCwK+cnfJZ6wWp0tw9Xy0fu2gyy46wOTxBLo2ZsmmcpBlnLnI?= =?Windows-1252?Q?IJFKVKp4nx3FRDwsOEUw+0VPvPXLQseLnaZZCcNljxnDkFB4Bggmyf5R?= =?Windows-1252?Q?5Qi+2BLXNbXOWapRF5w2RYAO9wa5FqizXez0QtdGw0fIl+gMG0fbltmi?= =?Windows-1252?Q?8Lab2RSAa8nFfMMvtByIEipczD0Ryrlt54ymzGbTSS3TP8BoWO1Bfj1O?= =?Windows-1252?Q?6HOeuOujL5k/xTBVhRSTq6jH+oLZahBYecI9veFFWzEI5FWHf/3ivJmB?= =?Windows-1252?Q?FXAsFT6IsriShSE+f1S/evD0jLLAJN7/705Rw3fsa7DqCqBoGLBIhRZA?= =?Windows-1252?Q?g77rBxACpK+2F4Bhn/uiVsHCbBS7fEnaLXHG8kRaz2t7AeMB7naDUu62?= =?Windows-1252?Q?uCzfw45hOKcfvj0Zhd/bsmJ4Il9Z7l9UP5moNqh4fry+ZeNDM8md0O/k?= =?Windows-1252?Q?sF4+IKXPkqAwUXB4/H9Ne2V4CTgr4/yE12AClEXjDyWs6uicRYLzsQvl?= =?Windows-1252?Q?drWxEjeh1esHv2vi6VYt66GEA1OfdGX5Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0709;5:vsCizOMalU7zzQdEfBN632xu8GfFE6mD+F0Wzcxh00ilkINAIZBbjZ+DTLaImqkpjQp9eeDNcW2eNWAUIpM1bob/YUg0B+If1n0VQK0IeabmshgQ+6UHIZW8G5d908uCye6xDNa5Z6gfXUvZY2wLIg==;24:OGL1A8fgrfJIajDP5UI5eHPxZ6Rc91NA2A7MbelaRdrG81/eD2uDeKjZj35dMv0AHfkpo1TTPfup0PaJ7GwqI2U4WV0hZ+3CaIx5zpYWNKg=;20:akMRqsSl0V85kNkDPtk8X/8Zc3GN0LqRLFcEuPvKKA9EwTpowyP2jOqxOQmaoLbUbfUHeVnb4Bv2pqdt5gkIWUWfLKPsxuR1bF0rj6hXStEmyyZgq3AmiRTaJj4YR2u/Mv6t7hYrfL9KbsXGnWFAI0r6K2sGBRCt/MFrvO4Zphgh/XdzcyrBs+y6o6e6jh9wQfsbUJchGrI3mRMym7EaNANJ2yE+W1U18m1s6YMo4a9mgqXv7ge0wHZU0PF0Cc9e SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2015 19:17:04.0270 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0709 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/20/2015 12:41 PM, Mark Rutland wrote: > On Tue, Oct 20, 2015 at 07:36:39PM +0200, Borislav Petkov wrote: >> On Tue, Oct 20, 2015 at 06:26:55PM +0100, Mark Rutland wrote: >>>> Btw, how much of this is implementing generic A57 functionality? >>> >>> The driver is entirely A57 generic. >>> >>>> If a lot, can we make this a generic a57_edac driver so that multiple >>>> vendors can use it? >>> >>> Yes. >> >> Ok, cool. >> >>>> How fast and how ugly can something like that become? >>> >>> Not sure I follow. >> >> In the sense that some vendor might require just a little bit different >> handling or maybe wants to read some vendor-specific registers in >> addition to the architectural ones. >> >> Then we'll start adding vendor-specific hacks to that generic driver. >> And therefore the question how fast and how ugly such hacks would >> become. >> >> I guess we'll worry about that when we get there... >> >> So Brijesh, if you only need generic, architectural functionality, >> please call it arm64_edac or so and let's add it so that other arm64 >> vendors can use it too. > > Please note that this is specific to Cortex-A57, not ARMv8 or aarch64. > > It is an IMPLEMENTATION DEFINED feature as implemented by Cortex-A57, > which by definition is not implemented by other CPUs. It is not provided > by the ARM architecture. > > So this cannot be arm64_edac, but could potentially be cortex_a57_edac. > Yes code is generic to Cortex A57 and naming it cortex_a57_edac sounds good. Also I will follow your suggestion and remove DT binding and use MIDR. > Thanks, > Mark. >