From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753044AbbJUCRF (ORCPT ); Tue, 20 Oct 2015 22:17:05 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:35061 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752084AbbJUCRB (ORCPT ); Tue, 20 Oct 2015 22:17:01 -0400 Subject: Re: [PATCH 3/4] thermal: rockchip: change the TSHUT default state To: Doug Anderson References: <1445332264-6054-1-git-send-email-wxt@rock-chips.com> <1445332264-6054-4-git-send-email-wxt@rock-chips.com> <5626EEB2.50101@gmail.com> Cc: Caesar Wang , Heiko Stuebner , "linux-pm@vger.kernel.org" , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , Eduardo Valentin , "open list:ARM/Rockchip SoC..." , Zhang Rui , "linux-arm-kernel@lists.infradead.org" From: Caesar Wang Message-ID: <5626F597.8060601@gmail.com> Date: Wed, 21 Oct 2015 10:16:55 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Doug, 在 2015年10月21日 10:14, Doug Anderson 写道: > Caesar, > > On Tue, Oct 20, 2015 at 6:47 PM, Caesar Wang wrote: >> Doug, >> >> 在 2015年10月21日 00:01, Doug Anderson 写道: >> >> Caesar, >> >> On Tue, Oct 20, 2015 at 2:11 AM, Caesar Wang wrote: >> >> As the TRM says, the TSHUT default state is high active. >> In general, the TSHUT state can get from the dts. Otherwise >> it gets the state from this. >> >> Can you point at where the TRM says that the default state is high active? >> >> With the manual I have, I look at TSADC_AUTO_CON and I look at the >> description of "Bit 8". It says that "tshut polarity" is 0 for low >> active and 1 for high active. It then said that the Reset Value is 0. >> >> ...the "Reset Value" in tables like this is notoriously unreliable, so >> I can totally believe that it's wrong. If you can point me at the >> part of the TRM that says that TSHUT is high active by default then I >> can confirm that for you. ;) >> >> >> Okay, I know that's my wrong, the polarity is high or low can be selected. >> :-( >> >> I remember the veyron why is the default HiGH active, since the opt is >> connected to the PMIC.(we need think about the devices) >> >> Why is the evb board LOW active, since the opt didn't connected to the >> devices. TSHUT is depend on the CRU to work. > I think we can drop this patch then, right? Any boards that need a > change from the default can just set "rockchip,hw-tshut-polarity", > right? Yep, we should drop this patch. I'm ready resend the patchs. > -Doug > -- Thanks, Caesar