From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753465AbbJUHBK (ORCPT ); Wed, 21 Oct 2015 03:01:10 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:20116 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753361AbbJUHBH (ORCPT ); Wed, 21 Oct 2015 03:01:07 -0400 X-AuditID: cbfec7f5-f794b6d000001495-b7-5627382d9c71 Message-id: <5627382C.4040207@samsung.com> Date: Wed, 21 Oct 2015 09:01:00 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Fida Mohammad Cc: Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org, LKML , Muhammad Falak , Simon Guinot Subject: Re: [PATCH] leds: leds-netxbig.c: Use devm_led_classdev_register References: <1445371592-24228-1-git-send-email-fmthoker@gmail.com> In-reply-to: <1445371592-24228-1-git-send-email-fmthoker@gmail.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsVy+t/xK7q6FuphBjffqVkc3TmRyWL3w/Os Fqu/v2SyuLxrDpvF1jfrGC1273rKarH+CZcDu8fOWXfZPVZefsDksWf+D1aPz5vkAliiuGxS UnMyy1KL9O0SuDLO7tvFUvBduOJ1+1W2BsapAl2MHBwSAiYSJ59YdTFyApliEhfurWfrYuTi EBJYyijx4nMPK4TzjFHi+sdmZpAqXgEtiffzHrCD2CwCqhLLtt4Bs9kEDCV+vnjNBGKLCkRI /Dm9jxWiXlDix+R7LCC2iICaxOUlf1hAhjILXGaUuPj/GyNIQljAU+LSpxNsILaQgJPE8i8t YDangLPE6ufPwWxmAWuJlZO2MULY8hKb17xlnsAoMAvJjllIymYhKVvAyLyKUTS1NLmgOCk9 10ivODG3uDQvXS85P3cTIyS0v+5gXHrM6hCjAAejEg/vh4VqYUKsiWXFlbmHGCU4mJVEeI/o qYcJ8aYkVlalFuXHF5XmpBYfYpTmYFES5525632IkEB6YklqdmpqQWoRTJaJg1OqgVHc3MvR f817j1ksZQkvcxbUz5XiuVJy1zSuzTzuy4El/Z9lp/4yaw7f9VPpjaVq1WK+Y682hnw0Wuz6 06/T3PQ8iwpD5aT4J+KJn2/X/+teFeHlemoP5ySRuxXTX/HF3qjlmz/3bqn1breCnlu1aoEf F777keJjnPjobinLZ0H5O203UvZf1FFiKc5INNRiLipOBADmZJvuaQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fida, On 10/20/2015 10:06 PM, Fida Mohammad wrote: > Use resource managed function devm_led_classdev_register to make > error path simpler. Consequently, removed a goto call and > remove function made simpler. > > Signed-off-by: Fida Mohammad > --- > drivers/leds/leds-netxbig.c | 25 +++++-------------------- > 1 file changed, 5 insertions(+), 20 deletions(-) > > diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c > index 25e4197..639f8bd 100644 > --- a/drivers/leds/leds-netxbig.c > +++ b/drivers/leds/leds-netxbig.c > @@ -299,10 +299,6 @@ static struct attribute *netxbig_led_attrs[] = { > }; > ATTRIBUTE_GROUPS(netxbig_led); > > -static void delete_netxbig_led(struct netxbig_led_data *led_dat) > -{ > - led_classdev_unregister(&led_dat->cdev); > -} > > static int > create_netxbig_led(struct platform_device *pdev, > @@ -343,7 +339,7 @@ create_netxbig_led(struct platform_device *pdev, > if (led_dat->mode_val[NETXBIG_LED_SATA] != NETXBIG_LED_INVALID_MODE) > led_dat->cdev.groups = netxbig_led_groups; > > - return led_classdev_register(&pdev->dev, &led_dat->cdev); > + return devm_led_classdev_register(&pdev->dev, &led_dat->cdev); > } > > static int netxbig_led_probe(struct platform_device *pdev) > @@ -367,32 +363,21 @@ static int netxbig_led_probe(struct platform_device *pdev) > > for (i = 0; i < pdata->num_leds; i++) { > ret = create_netxbig_led(pdev, &leds_data[i], &pdata->leds[i]); > - if (ret < 0) > - goto err_free_leds; > + if (ret < 0) { > + gpio_ext_free(pdata->gpio_ext); > + return ret; > + } > } > > platform_set_drvdata(pdev, leds_data); > > return 0; > > -err_free_leds: > - for (i = i - 1; i >= 0; i--) > - delete_netxbig_led(&leds_data[i]); > - > - gpio_ext_free(pdata->gpio_ext); > - return ret; > } > > static int netxbig_led_remove(struct platform_device *pdev) > { > struct netxbig_led_platform_data *pdata = dev_get_platdata(&pdev->dev); > - struct netxbig_led_data *leds_data; > - int i; > - > - leds_data = platform_get_drvdata(pdev); > - > - for (i = 0; i < pdata->num_leds; i++) > - delete_netxbig_led(&leds_data[i]); > > gpio_ext_free(pdata->gpio_ext); > > Thanks for the patch. Always when submitting patches please cc also the author. I know that this is a simple optimization, but nevertheless an ack from the author, who can test the patch on the hardware, is valuable. Cc Simon. -- Best Regards, Jacek Anaszewski