From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753741AbbJUIJL (ORCPT ); Wed, 21 Oct 2015 04:09:11 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:51057 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753355AbbJUIJC (ORCPT ); Wed, 21 Oct 2015 04:09:02 -0400 Subject: Re: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default To: Tony Lindgren References: <1444819456-26728-1-git-send-email-rogerq@ti.com> <1444819456-26728-3-git-send-email-rogerq@ti.com> <20151019160158.GB22043@atomide.com> CC: , , , , , From: Roger Quadros Message-ID: <56274810.9070301@ti.com> Date: Wed, 21 Oct 2015 11:08:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151019160158.GB22043@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/10/15 19:01, Tony Lindgren wrote: > * Roger Quadros [151014 03:48]: >> Let's keep the SSI ports disabled in the omap3.dtsi to avoid >> getting the following noise on the console for boards that don't >> use the SSI ports. >> >> "omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)" >> >> As omap3-n900 uses one SSI port, mark it enabled there. > > This is the wrong way around.. The SSI ports are there on all omap3 SoCs, > we do want to have the struct device created for them. It's best to have > the driver probe and then idle SSI and bail out. Marking something with > status = "disabled" should be only used if you really want to avoid kernel > touching the device at all, for example, if something is managed from > the start by a copropcessor. Agreed. Please ignore this patch. cheers, -roger > > >> Signed-off-by: Roger Quadros >> --- >> arch/arm/boot/dts/omap3-n900.dts | 1 + >> arch/arm/boot/dts/omap3.dtsi | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts >> index 5f5e0f3..bdb72fb 100644 >> --- a/arch/arm/boot/dts/omap3-n900.dts >> +++ b/arch/arm/boot/dts/omap3-n900.dts >> @@ -949,6 +949,7 @@ >> }; >> >> &ssi_port1 { >> + status = "ok"; >> pinctrl-names = "default"; >> pinctrl-0 = <&ssi_pins>; >> >> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi >> index 8a2b253..25b0b37 100644 >> --- a/arch/arm/boot/dts/omap3.dtsi >> +++ b/arch/arm/boot/dts/omap3.dtsi >> @@ -815,6 +815,7 @@ >> interrupt-parent = <&intc>; >> interrupts = <67>, >> <68>; >> + status = "disabled"; >> }; >> >> ssi_port2: ssi-port@4805b000 { >> @@ -828,6 +829,7 @@ >> interrupt-parent = <&intc>; >> interrupts = <69>, >> <70>; >> + status = "disabled"; >> }; >> }; >> }; >> -- >> 2.1.4 >>