From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>,
arm@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
Kevin Hilman <khilman@linaro.org>
Subject: Re: [PATCH] MAINTAINERS: ARM: EXYNOS: Add documentation and dt-bindings
Date: Wed, 21 Oct 2015 10:45:18 +0200 [thread overview]
Message-ID: <5627509E.6090503@osg.samsung.com> (raw)
In-Reply-To: <1445391203-3819-1-git-send-email-k.kozlowski@samsung.com>
Hello Krzysztof,
Patch looks good to me, I've only one comment.
On 10/21/2015 03:33 AM, Krzysztof Kozlowski wrote:
> Extend the Samsung Exynos maintainer entry to match SoC documentation
> and SoC dt-bindings directories. Without that some files, like
> bindings/arm/samsung/pmu.txt, are not matched by existing patterns.
>
> This also may serve as a hint where new documentation and bindings (not
> matching specific subsystem) should be put.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b556aad90930..cad7b6b628b2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1459,6 +1459,8 @@ F: drivers/*/*s3c2410*
> F: drivers/*/*/*s3c2410*
> F: drivers/spi/spi-s3c*
> F: sound/soc/samsung/*
> +F: Documentation/arm/Samsung/
That there is also a Documentation/arm/Samsung-S3C24XX/ so
I think this should be Documentation/arm/Samsung*/ instead.
> +F: Documentation/devicetree/bindings/arm/samsung/
> N: exynos
>
> ARM/SAMSUNG MOBILE MACHINE SUPPORT
>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-10-21 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 1:33 [PATCH] MAINTAINERS: ARM: EXYNOS: Add documentation and dt-bindings Krzysztof Kozlowski
2015-10-21 8:45 ` Javier Martinez Canillas [this message]
2015-10-21 12:43 ` Krzysztof Kozlowski
2015-10-21 13:08 ` Javier Martinez Canillas
2015-10-22 1:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5627509E.6090503@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).