From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932231AbbJUIw0 (ORCPT ); Wed, 21 Oct 2015 04:52:26 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33106 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752197AbbJUIwW (ORCPT ); Wed, 21 Oct 2015 04:52:22 -0400 Subject: Re: [Y2038] [PATCH] hp_sdc: fixed y2038 problem To: Arnd Bergmann , y2038@lists.linaro.org References: <1445161459-26918-1-git-send-email-pingbo.wen@linaro.org> <5041745.xAgMz1TQSE@wuerfel> Cc: dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org From: Pingbo Wen Message-ID: <56275240.5040907@linaro.org> Date: Wed, 21 Oct 2015 16:52:16 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5041745.xAgMz1TQSE@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, October 19, 2015 05:01 PM, Arnd Bergmann wrote: > On Sunday 18 October 2015 17:44:19 WEN Pingbo wrote: >> Two replacements happened in this patch: >> 1. using timespec64 to prevent time overflow in 2038 >> 2. using ktime_get_ts64 to avoid wall time issues(leap second, etc) >> >> Signed-off-by: WEN Pingbo >> > > The patch looks correct, but I think this could be written a little > simpler and clearer using ktime_get() or ktime_getns(). > That make sense, Maybe it can save a sec shift operation. I will check it later. Pingbo