From: Heiko Schocher <hs@denx.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] regulator, dt: add dt support for tps6502x regulator
Date: Wed, 21 Oct 2015 14:52:51 +0200 [thread overview]
Message-ID: <56278AA3.3060109@denx.de> (raw)
In-Reply-To: <20151021121925.GC8232@sirena.org.uk>
Hello Mark,
Am 21.10.2015 um 14:19 schrieb Mark Brown:
> On Mon, Oct 19, 2015 at 08:27:13AM +0200, Heiko Schocher wrote:
>
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/tps65023.dtsi
>
> If this file is needed there is something broken, if this file is not
> needed then it is just noise since everything in it needs to be
> overridden by users anyway. Either way please remove it.
Uh, I thought to do it like:
arch/arm/boot/dts/tps65217.dtsi
but, okay, removed.
>> + vldo2_reg: regulator@4 {
>> + reg = <4>;
>> + regulator-compatible = "vldo2", "regulator-compatible";
>
> Modern bindings no longer use regulator-compatible, they just use the
> node name - please look at recently added bindings for examples.
removed.
Thanks for the review!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2015-10-21 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 7:14 [PATCH] regulator, dt: add dt support for tps6502x regulator kbuild test robot
2015-10-19 6:27 ` Heiko Schocher
2015-10-19 7:14 ` [RFC PATCH] regulator, dt: tps6502x_parse_dt_data() can be static kbuild test robot
2015-10-21 12:19 ` [PATCH] regulator, dt: add dt support for tps6502x regulator Mark Brown
2015-10-21 12:52 ` Heiko Schocher [this message]
2015-10-21 16:17 ` Mark Brown
2015-10-22 4:51 ` Heiko Schocher
2015-10-22 12:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56278AA3.3060109@denx.de \
--to=hs@denx.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).