From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754884AbbJUMw4 (ORCPT ); Wed, 21 Oct 2015 08:52:56 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:58770 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754018AbbJUMwz (ORCPT ); Wed, 21 Oct 2015 08:52:55 -0400 X-Auth-Info: suiJAhsH1Xg/sf4WUgwPmvR7ftGP54q2hJAwUt5P2wI= Subject: Re: [PATCH] regulator, dt: add dt support for tps6502x regulator To: Mark Brown References: <1445236033-27747-1-git-send-email-hs@denx.de> <20151021121925.GC8232@sirena.org.uk> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Liam Girdwood Reply-To: hs@denx.de From: Heiko Schocher Message-ID: <56278AA3.3060109@denx.de> Date: Wed, 21 Oct 2015 14:52:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20151021121925.GC8232@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark, Am 21.10.2015 um 14:19 schrieb Mark Brown: > On Mon, Oct 19, 2015 at 08:27:13AM +0200, Heiko Schocher wrote: > >> --- /dev/null >> +++ b/arch/arm/boot/dts/tps65023.dtsi > > If this file is needed there is something broken, if this file is not > needed then it is just noise since everything in it needs to be > overridden by users anyway. Either way please remove it. Uh, I thought to do it like: arch/arm/boot/dts/tps65217.dtsi but, okay, removed. >> + vldo2_reg: regulator@4 { >> + reg = <4>; >> + regulator-compatible = "vldo2", "regulator-compatible"; > > Modern bindings no longer use regulator-compatible, they just use the > node name - please look at recently added bindings for examples. removed. Thanks for the review! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany