From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756052AbbJUQXh (ORCPT ); Wed, 21 Oct 2015 12:23:37 -0400 Received: from mail-bl2on0084.outbound.protection.outlook.com ([65.55.169.84]:35916 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755912AbbJUQX2 (ORCPT ); Wed, 21 Oct 2015 12:23:28 -0400 X-Greylist: delayed 75979 seconds by postgrey-1.27 at vger.kernel.org; Wed, 21 Oct 2015 12:23:28 EDT Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NWKW6X-07-HQ1-02 X-M-MSG: Subject: Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC To: Andre Przywara , Borislav Petkov , Hanjun Guo References: <1445282597-18999-1-git-send-email-brijeshkumar.singh@amd.com> <20151019205236.GB453@leverpostej> <56266F7E.6030404@amd.com> <20151020165744.GE31130@pd.tnic> <20151020172654.GC4943@leverpostej> <20151020173639.GH31130@pd.tnic> <5626F09F.4050107@huawei.com> <20151021093536.GA3575@pd.tnic> <5627627A.9010906@arm.com> CC: , Mark Rutland , "Arnd Bergmann" , , , , , , , , , , , Huxinwei From: Brijesh Singh Message-ID: <5627BBC0.2000008@amd.com> Date: Wed, 21 Oct 2015 11:22:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5627627A.9010906@arm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(377454003)(189002)(479174004)(199003)(52314003)(24454002)(86362001)(15975445007)(93886004)(2950100001)(54356999)(87266999)(76176999)(65816999)(77096005)(5008740100001)(92566002)(59896002)(36756003)(50986999)(46102003)(105586002)(65956001)(83506001)(47776003)(19580405001)(19580395003)(64126003)(65806001)(4001350100001)(23676002)(80316001)(64706001)(5001770100001)(33656002)(97736004)(106466001)(11100500001)(50466002)(189998001)(87936001)(5001920100001)(101416001)(5007970100001)(5004730100002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0716;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;2:QPlJuClRFCSaMoik9zeaT2pr3ZVwuP5LpDmjZkjY87svIznszWK9/aSGhOIcRCJk6n9/zMwgwe+YdEtCwTEp08tsWUY0fZwt0fzt12HsJsuA6O61ziGI2RtAaTJDZxssPOJ9ynczXkn5MHcijfqXtGjGiUFibm5ohJHVpnfboNY=;3:ozlXc7A9MpYIRE/x6laiJ95SIJbHqtg75YnDBC+fcGidV27K62AoAf6C/RmjLRTaiasSs8BEVc+MuhxgakyAGEU5VYb7OOm7ooGBX3GSOVv8y+dT3kKtIsTHnrtW7+79vGb2vqDuUX/eTVGEUtIB0vsRxQ6rWbIy0oJQGXCRQMyG0eS/zTwoFGRbysP9iICYrgC/mnfsNIK+IeO1E+dLIPqLatB3GoLXQSelOcQWqgLeaG8ySdpx1K+84OBfb1CiyoxQ9ndqJKq+bv0dL0cpYg==;25:H8BREL1wlIsbn79XCdin8O6qdED/r+Zpy9tEuaO0Qcvj4N4dLB454l3fFL6rVvNUlEdXSWx+JFxsnt/IPq+F4naDm/afo5AMgXdGyjaLHQlftgsOnN4o5fuP+fI5S3mQPcOq9GOfy1IwInLOplunBEX/EYUPAbd2GBOEb6T6354bVS1/tW84VeqvH1AlnNx0zvNpsLRFnOWYNiEIv0PckxoaXnFl+y1wP2FvrtBh7i9EEeOtQG1qWcF2rc6QgOQO5Y+0siWlVmDaS5Td+C4WYQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(42134001)(42139001);SRVR:CY1PR12MB0716; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;20:i4viPZhP3m3gDFFqwiAFeoGCDLjdlaOF/pd5EX5fvwVVwSBiujQWt0w68ycAqenI9OCHD6Bwo2DElQk4bn575x/i/xAdwFmFig0UQGnrXtEY2+8CKlnPwTGyOuuJv7paZ5KIB9jZ0lcovAJPULfUi6EkoimpddpdhBpvOhxGIkQ7ivRHMb1JP2vhZB+JUdD/gdIq2TKH1iqgTTdifOKo6WT7VNaXwNK+Id+Y3pK/N8Fyn8Z8fndGRSFjTu/a9x0j8L9kaP9LJsdpGvJlVL1s4xNrGYoAwNxU6eYbRqEr8XTo1z+Q83ApgQo+F4hRXNVrHgs8K8BYIYXCdEfT8xMMUo37gZKIcOUkScDSdACS/E2iK5y0yrNshWumMLlbWYH7WTAECpcYy1nJ9gx53PoTfhNpovGWT6YEHD73dUFGNJLN63H7ZHyksz58wanZlc1SQLw/qerkEfS/xFhCcD8Mo74iJxWx1k7AnQYGY7c/O5hArqEbLjtw322rYvFE9OkH;4:yVcshX9fEpYjqLFnWPCuvKseNaCoMlKp+LtnJ/ZPt2AmmX59PSpzNim4CXUhJPzuWNYhyCzIIHDMnKVcpg5wEVrlaDtEpFhIE/ajzning8YJPuiAhQGvxQ3YIZjjqmX2HmEoDxMWCLk2xZK5F1gzsGzB6zGZCk1xwyjNxfoNIDLDzHlyYJODan73tNyU2BQe8mPkbt95VTtcJNy9C8Z2rAsGbM2+skBTP6q++pr7KHUXjGGT07Z3aMEY46UwWhQV9XtKRstRTa/26gt0kPC7GZ4PMFDUrdMLo1nh95j61d10u+k+3CGgjVHHcX51U1aSg1bcq7C/sOLAwfJZgok/OhfcTRHa3XkTIKwgTPTGX16YvC4lXjCtBtODyXevP8ld X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(102115026);SRVR:CY1PR12MB0716;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0716; X-Forefront-PRVS: 073631BD3D X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwNzE2OzIzOkJORUZ6YjF2L1IwTUhLWU9EV3R6QnFod0dl?= =?utf-8?B?NFd5eUQxMWdYWVVJcy9iN2oxd0FQcCt2c1QxbWFaeEtiekpUY1ZuZXNmRXp1?= =?utf-8?B?TmJESXFkaXAvRlpmbVQ3SWVDWUdob0RRV256aGxGM1M0RWwrdDJTYlN3U0Na?= =?utf-8?B?TjhGUkczUFB0a3hod3NGU2Yva2UvYXB5ajByZHZzVmd2TkNPMDJ2TkVEbVVw?= =?utf-8?B?K3dQOUZRcnV0bk1XN3daVTRRbHBMTGtQaG4rNG42U3g1a3J5UkU2Skc0MDdF?= =?utf-8?B?QjZkRzZTWE9KYWFDMTEwekFoTkI1MlhiWnZzS2pTRGxHRFZKdXMzZjcvbmxo?= =?utf-8?B?a2RXLzdMTHoyUjZyQUVJRU0rbGhkTkNDVmRuc1dGYUN1OUxSMWZZRThDTWxu?= =?utf-8?B?WTB2VGpwajlvYk9rMmYrYTVGSkg3alVENWpUTGM4YXVjRFBKbldSTmRETmxY?= =?utf-8?B?YU1Fc3FEWVB4NytCZ1d4bUtRWFhjYWJHTERIWlBFNU9obzhWOVVqMFNSOWd3?= =?utf-8?B?aHVkbWRnTCtTWTlRVWNXUTBmelhpMElOdHlBNlk5LzROQmhLVWoxbGZvcDA4?= =?utf-8?B?TFA2b3FONlA1bGFjeVMrL0dyNnk5L1V0dDU2S3FTQTYxdEp2ZUxUNzBUL3hF?= =?utf-8?B?UWFnNWdvMlJocG1TS3FjMmcvWHExYngxTGlwNzB0NGE0cnl4VmFsV2RqbHNy?= =?utf-8?B?MUlxN2lwWk9GSVVRK21nT2xnMVFKVXZ6cmJwS2ZrL0prUEpSMDlmd0xhaFVa?= =?utf-8?B?djAvdFpZQ1pzZ2MwV25JYkovMjk4eVB4Z2wvY0k1cllOaldTQTErRGRSbTZZ?= =?utf-8?B?bVNBUVBjK1gxU2NHdk1UbTE1WnZLYUdqSXVCdUw0cDZQendteFZ3cms5eE5C?= =?utf-8?B?cHJsNXM4VDVybmU3a3VqU1RlS0hjMlU0WFlNZXdjMDFFRTFpZWdDQkNjUU5F?= =?utf-8?B?VHBKWUhTUEdwN0lxUnpVVDFVNHcxNElZbmdwM29JNGx4TFRPZ1BETkVBNjN1?= =?utf-8?B?WTdUdUM4a2dlRmUrQVFYWUNOVnN6eHFuTmluWENaUElqNFZ5S25vbEd5eCtl?= =?utf-8?B?RU03N2JCYnoycU5zTGd3VXRKcjI5R1YrTklicnNyZURPVnJTYkhPaVV4OTFu?= =?utf-8?B?MW8rd2Jzb3JMZTlYU2R4NExsY2xxRUFHY245aDNTOUFLYVpLWDFFVXo3UmdE?= =?utf-8?B?SnArb2MzT05lVDZSeGh5bmErSUZObis0Y0VZRDd5QXpUR29ZaE1namlhcUlm?= =?utf-8?B?VUJYbUREZWErNjNwekt1ZDNVNE9INUFJSlBtSkJRRk5od1haS05TYzErUWxa?= =?utf-8?B?UjRiMTVLLzI0TVc5UDlISi9mbkxiWmpiM3Bib3dsdytmeDlqRlNyUmEvaTNK?= =?utf-8?B?cnNOUlFsUnlRaTJ4eGhvM21XN24zWlRlWm1NbVl1NkJwM3gxb2RqdEZWYm9R?= =?utf-8?B?aXVOWmVMUS9vMEppeGllUlhTcTNOeGJ6c0YyVFE4Z1Vvc285U2dib0d2VXdn?= =?utf-8?B?L1I5SEVFb3FwTVk3VEczcm1PSXhuNEVseCtaOEFVK05EWlFMb1YzYXYyOVY0?= =?utf-8?B?Y0phdWZkZWI5RXVKbEdGZUJkSnNkWnphb1FaYjBDcjAveWcxTE0zSCtJUmNU?= =?utf-8?B?bVpvczdJK3h1QWNwdy9pUlNyUk9HT2VSWmF4VVFZbkVISXlqWlJMaWRxTDBq?= =?utf-8?B?b2ZpZjJmM290UlBEeHB4eW1NWDNZQVcvZ2dqY2poaTNqTk9TZ0VRM0FSWGJ5?= =?utf-8?B?Tng4Wkk5YTZZcnZnQVdGZz09?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;5:wpT/efQu/po828na7jAL0jXaXOIhw3B9NZZCLoGV8I6hhY3gFTgJs//wRch0jTtmwi5NIjIP08APgzvQEzP2GqWTIwpdW7ElRESoNnf1yhisOiY/LF4lJdUqL98hYYntD3GyqdjTRcN63iDFco+0zQ==;24:tVH/dTvXsIygV6mLe08aP0mn75JkI+aCHNP/Nz3v7rU18iLAOd3gHzNcwQoBIeX0VI/Tiw3Qx280QRb9upNmWZeAhhDmIw0OglCjTzhnAWA=;20:886+KbXp0DV177oPFCrjtm3XLDggSk2o/3bW7+x8yXnV9e4otbyPjo4D6gqTRtR2fWazCHMnbGp3v8nCJhCCQtUgrTvWx6f9rbdfGyid4P9eZyBRqycm4rJ/JOYHYuqIC7x9ypZd7vl7TgVt4jV9IKBvW87sjcizLf8tAV6WgfNHbAU97Egkvhkh589nBpcUgC2exYhkUzg49z4u8/KBs61OM7F8IXhnWFNvSbx7lv6WF19WZQRGFs94PwFgOwfy SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2015 16:23:23.8760 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0716 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/21/2015 05:01 AM, Andre Przywara wrote: > Hi, > > On 21/10/15 10:35, Borislav Petkov wrote: >> On Wed, Oct 21, 2015 at 09:55:43AM +0800, Hanjun Guo wrote: >>> So I think the meaning of those error register is the same, but the way >>> of handle it may different from SoCs, for single bit error: >>> >>> - SoC may trigger a interrupt; >>> - SoC may just keep silent so we need to scan the registers using poll >>> mechanism. >>> >>> For Double bit error: >>> - SoC may also keep silent >>> - Trigger a interrupt >>> - Trigger a SEI (system error) >>> >>> Any suggestion to cover those cases? >> >> Well, I guess we can implement all those and have them configurable >> in the sense that a single driver loads, it has all functionality and >> dependent on the vendor detection, it does only what the vendor wants >> like trigger an interrupt or remain silent or ... > > I guess the firmware (running in EL3) will take precedence over this > driver anyway, so we could just optimistically implement all errors, as > the driver will just never see errors that are handled in firmware (?) > In case of a critical error for instance I expect the firmware to never > return to EL1. > >> >> Btw, in talking about this with Andre last night, he had the suggestion >> that this functionality is also in other implementations besides A57 so >> maybe the driver should be called arm_cortex_edac... > > Yeah, so looking at the A-72 and the A-53 TRM I see those registers to > be there as well. The A-72 and the A-57 versions look identical to me, > the A-53 version is only slightly different, but apparently still > compatible. > So I'd suggest to let this driver load on detecting all three MIDRs. > Should later revisions of any of those parts change the register > meaning, we could add a blacklist or specific MIDR detection. > > But let's just not assume the worst in the first place ;-) > Ok. Will make it generic cortex_arm64_edac. Will check MIDR and call appropriate CPUMERRSR_EL1 and L2MERRSR_EL1. Since I don't have A53 and A72 hence my testing will be limited to Cortex A57. > Cheers, > Andre. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >