From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932311AbbJUTww (ORCPT ); Wed, 21 Oct 2015 15:52:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:53698 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753500AbbJUTwt (ORCPT ); Wed, 21 Oct 2015 15:52:49 -0400 Subject: Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros To: Prarit Bhargava References: <1444940195-28272-1-git-send-email-mmarek@suse.com> <1444940195-28272-10-git-send-email-mmarek@suse.com> <5627E73B.9000502@redhat.com> Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, rds-devel@oss.oracle.com, netdev@vger.kernel.org From: Michal Marek Message-ID: <5627ED0D.20308@suse.com> Date: Wed, 21 Oct 2015 21:52:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5627E73B.9000502@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): > On 10/15/2015 04:16 PM, Michal Marek wrote: >> Otherwise make tags can't parse them: >> >> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1" >> ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name pattern "\1" >> ctags: Warning: drivers/acpi/processor_idle.c:64: null expansion of name pattern "\1" >> ctags: Warning: kernel/locking/lockdep.c:153: null expansion of name pattern "\1" >> ctags: Warning: kernel/workqueue.c:305: null expansion of name pattern "\1" >> ctags: Warning: kernel/rcu/rcutorture.c:133: null expansion of name pattern "\1" >> ctags: Warning: kernel/rcu/rcutorture.c:135: null expansion of name pattern "\1" >> ctags: Warning: net/rds/page.c:45: null expansion of name pattern "\1" >> ctags: Warning: net/ipv4/syncookies.c:53: null expansion of name pattern "\1" >> ctags: Warning: net/ipv6/syncookies.c:44: null expansion of name pattern "\1" > > I guarantee you're going to end up fixing this issue over and over again as more > code is added in. This is certainly going to happen, but it should be quickly spotted by anybody running make tags on linux-next. And 10 instances since the beginning of git is not too many. > OOC, why not fix ctags to recognize newlines? It's not ctags itself parsing the DEFINE_PER_CPU() macro, but a user-supplied regex specified on commandline. Which can only operate on single lines. Michal