From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755447AbbJUUoP (ORCPT ); Wed, 21 Oct 2015 16:44:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48069 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753367AbbJUUoO (ORCPT ); Wed, 21 Oct 2015 16:44:14 -0400 Subject: Re: [PATCH] usnix: correctly handle kzalloc return value To: Insu Yun , umalhi@cisco.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <1445108816-7616-1-git-send-email-wuninsu@gmail.com> Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu From: Doug Ledford Openpgp: id=AE6B1BDA122B23B4265B1274B826A3330E572FDD; url=pgp.mit.edu Organization: Red Hat, Inc. Message-ID: <5627F91C.9050102@redhat.com> Date: Wed, 21 Oct 2015 16:44:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445108816-7616-1-git-send-email-wuninsu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ft94oJLCkavKJ6wThAhwK64nBRsruStwq" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ft94oJLCkavKJ6wThAhwK64nBRsruStwq Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/17/2015 03:06 PM, Insu Yun wrote: > Since kzalloc returns memory address, not error code, > it should be checked whether it is null or not.=20 >=20 > Signed-off-by: Insu Yun Thanks, applied. > --- > drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c b/drivers/in= finiband/hw/usnic/usnic_ib_qp_grp.c > index db3588d..a678a66 100644 > --- a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c > +++ b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c > @@ -221,8 +221,8 @@ create_roce_custom_flow(struct usnic_ib_qp_grp *qp_= grp, > =20 > /* Create Flow Handle */ > qp_flow =3D kzalloc(sizeof(*qp_flow), GFP_ATOMIC); > - if (IS_ERR_OR_NULL(qp_flow)) { > - err =3D qp_flow ? PTR_ERR(qp_flow) : -ENOMEM; > + if (!qp_flow) { > + err =3D -ENOMEM; > goto out_dealloc_flow; > } > qp_flow->flow =3D flow; > @@ -296,8 +296,8 @@ create_udp_flow(struct usnic_ib_qp_grp *qp_grp, > =20 > /* Create qp_flow */ > qp_flow =3D kzalloc(sizeof(*qp_flow), GFP_ATOMIC); > - if (IS_ERR_OR_NULL(qp_flow)) { > - err =3D qp_flow ? PTR_ERR(qp_flow) : -ENOMEM; > + if (!qp_flow) { > + err =3D -ENOMEM; > goto out_dealloc_flow; > } > qp_flow->flow =3D flow; >=20 --=20 Doug Ledford GPG KeyID: 0E572FDD --ft94oJLCkavKJ6wThAhwK64nBRsruStwq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJWJ/kcAAoJELgmozMOVy/djlwP/0Dea+D3sxy0kfFtxArjkJkE 58jjYOMVjZ+R3nUTfz7IT2HVsJn2RGKr+ZT8yrb/P90vRu7jcM4FYJr7lF0eoFY4 GU6VtPwoKKs/HoYowRrmeG2mNBxnxD/NqDUNX3clskuEbX9DriENxB7Zz5tmygvQ 8IDvHO6yYSIqNmbHDQigWDpAQglmzjBklhC0e1nronbKaqvFORb/BM89kTd7DvMc TDKcVEKlrYmsTFq6JqctGp9wxXlJKZxPrwbvYN8FwXRS6m1QHbqI6kZFepWkUp+O N/TZgN0qHMTs6lNwnKM0A2y44ffvRchvlhN4bb3wCW8jGHHy3N48YhUQNZXmlIVt E5ZV8ivDBcBHDqEL6lzX8VinQRwV5+HdgBoI+/gWJFigjU5aa7OuYTpWORK5dvmC I7eQ0B6Blmu2snXS0G4tKsjFoTpWDkiOZsB5+Fr8yXtiUBCNGvhWVspGwipUuQg5 k/+J+dR6NxyvFq6o5FpyDMT2KuFW0a13FnP1kRHOKG/ceLG3NZy+2rIYJNwMugET QxW+W47+DntqVTCWt1aMHlWth5nSHFW6t6hhySkz9giPWKZZ6xLS3O3izIauwUZ6 y/pfRjrUCTznRT2JPtEj4ZTPvdqFYTJFHqBhmdVDeQNzo3doXMT2DsxxkzS89Bc7 hzsWieSkS9t6C2dF77g+ =ic4f -----END PGP SIGNATURE----- --ft94oJLCkavKJ6wThAhwK64nBRsruStwq--