From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756013AbbJVBCH (ORCPT ); Wed, 21 Oct 2015 21:02:07 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:64605 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753233AbbJVBB4 (ORCPT ); Wed, 21 Oct 2015 21:01:56 -0400 X-AuditID: cbfec7f5-f794b6d000001495-33-5628358175eb Subject: Re: [PATCHv2] ARM: dts: use vmmc-supply of emmc/sd for exynos5422-odroidxu3 To: Anand Moon , Kukjin Kim , Javier Martinez Canillas References: <1445345793-5189-1-git-send-email-linux.amoon@gmail.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56283582.5010908@samsung.com> Date: Thu, 22 Oct 2015 10:01:54 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1445345793-5189-1-git-send-email-linux.amoon@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xa7qNphphBscfqVnMP3KO1eLN2zVM Fq9fGFr0P37NbLHp8TVWi8u75rBZzDi/j8li3cZb7A4cHjtn3WX32LSqk81j85J6jy39QF7f llWMHp83yQWwRXHZpKTmZJalFunbJXBl7Dqxj7GgVa7i2s+XzA2Mf8S7GDk5JARMJHr+z2aD sMUkLtxbD2RzcQgJLGWU+NC2kQXC+cIo8efSf3aQKmGBMIkN/78ygtgiAlUS+9q3g3ULCbhI tE4+zgrSwCzQzihx5y3EWDYBY4nNy5eA2bwCWhLrPn8Fs1kEVCVW7v7MDGKLCkRITJzQwApR IyjxY/I9oM0cHJwCrhK3TmWDmMwCehL3L2qBVDALyEtsXvOWeQKjwCwkDbMQqmYhqVrAyLyK UTS1NLmgOCk910ivODG3uDQvXS85P3cTIyTkv+5gXHrM6hCjAAejEg+vxn/1MCHWxLLiytxD jBIczEoivI+0NcKEeFMSK6tSi/Lji0pzUosPMUpzsCiJ887c9T5ESCA9sSQ1OzW1ILUIJsvE wSnVwHjALZO50enh42Dmh8ofAxlOFnVadcqFC+944Pp3DsuPZy94Yxtspsa+6GCxNehwfCmX +EDiVfC/yS6qZzuZdb7/+xT3ifvZvqlmahX96z98m1qw5QeTwKQV+/asD0ufNOvxypxngatW xjf77Hw7d0LNHwVDnxc2/z/LWvzqYL21WO2yCrdU/SMlluKMREMt5qLiRABr+cfEdQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.10.2015 21:56, Anand Moon wrote: > Changes need for host controller to detect UHS-I highspeed cards. > Changes in VDDQ_MMC2 voltage range help scale > the required voltage to detect and load the microSD cards. Thanks for updating description of commit. > > Signed-off-by: Anand Moon > --- > Changes based on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.4-next/dt-samsung branch > > Changes: > Drop the ranp_delay for LDO9. > > Thanks to : Krzysztof, Doug Anderson, Jaehoon Chung for helping > me out figure out the mmc core requirement. > > Also drop the previous changes: > use cd-gpio method to detect sd-card. > Added UHS-I bus speed support. > > [ 4.713553] random: nonblocking pool is initialized > [ 4.718423] 14530000.hdmi supply hdmi-en not found, using dummy regulator > [ 4.726206] exynos-drm exynos-drm: bound 14400000.fimd (ops fimd_component_ops) > [ 4.732555] exynos-drm exynos-drm: bound 14450000.mixer (ops mixer_component_ops) > [ 4.740180] exynos-drm exynos-drm: bound 14530000.hdmi (ops hdmi_component_ops) > [ 4.746936] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). > [ 4.753428] [drm] No driver support for vblank timestamp query. > [ 4.940794] Console: switching to colour frame buffer device 274x77 > [ 4.995344] exynos-drm exynos-drm: fb0: frame buffer device > [ 5.024573] [drm] Initialized exynos 1.0.0 20110530 on minor 0 > [ 5.031164] exynos-dwc3 usb@12000000: no suspend clk specified > [ 5.054571] usb 2-1: new full-speed USB device number 2 using exynos-ohci > [ 5.159527] dwmmc_exynos 12220000.mmc: Busy; trying anyway > [ 5.163705] mmc_host mmc1: Timeout sending command (cmd 0x202000 arg 0x0 status 0x0) > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 1af5bdc..a4be3e0 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -182,9 +182,10 @@ > > ldo13_reg: LDO13 { > regulator-name = "vdd_ldo13"; > - regulator-min-microvolt = <2800000>; > + regulator-min-microvolt = <1800000>; You did not convinced me in previous discussion about the change to 1.8V. I said that: > On the same diagram few lines below: > VDDQ_MMC2: 2.8V 250mA You responded: > You are correct. So I am confused. Are you sure that this SD card block can/should operate on 1.8V? Have you actually tried this? > regulator-max-microvolt = <2800000>; > regulator-always-on; > + regulator-ramp-delay = <12000>; NAK We've been talking about this. Sooo maaaanyyyy times. If you are going to send v3 please come up with detailed reasoning, which will convince my stubborn mind. Best regards, Krzysztof > }; > > ldo15_reg: LDO15 { > @@ -213,6 +214,7 @@ > regulator-min-microvolt = <2800000>; > regulator-max-microvolt = <2800000>; > regulator-always-on; > + regulator-ramp-delay = <12000>; > }; > > ldo24_reg: LDO24 { > @@ -338,6 +340,7 @@ > samsung,dw-mshc-ddr-timing = <0 2>; > samsung,dw-mshc-hs400-timing = <0 2>; > samsung,read-strobe-delay = <90>; > + vmmc-supply = <&ldo3_reg>; > pinctrl-names = "default"; > pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>; > bus-width = <8>; > @@ -355,6 +358,8 @@ > pinctrl-names = "default"; > pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>; > bus-width = <4>; > + vmmc-supply = <&ldo19_reg>; > + vqmmc-supply = <&ldo13_reg>; > cap-sd-highspeed; > }; > >