* [PATCH] leds: leds-wrap.c: Use devm_led_classdev_register
@ 2015-10-21 10:58 Fida Mohammad
2015-10-22 7:15 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Fida Mohammad @ 2015-10-21 10:58 UTC (permalink / raw)
To: Bryan Wu, Richard Purdie, Jacek Anaszewski, linux-leds, LKML,
Muhammad Falak
Cc: Kristian Kielhofner, Fida Mohammad
Use of resource managed function devm_led_classdev_register to
make initialization path simpler. Also removed redundant remove
function.
Signed-off-by: Fida Mohammad <fmthoker@gmail.com>
---
drivers/leds/leds-wrap.c | 26 ++++----------------------
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/drivers/leds/leds-wrap.c b/drivers/leds/leds-wrap.c
index 1ba3def..c5ff4b4 100644
--- a/drivers/leds/leds-wrap.c
+++ b/drivers/leds/leds-wrap.c
@@ -76,39 +76,21 @@ static int wrap_led_probe(struct platform_device *pdev)
{
int ret;
- ret = led_classdev_register(&pdev->dev, &wrap_power_led);
+ ret = devm_led_classdev_register(&pdev->dev, &wrap_power_led);
if (ret < 0)
return ret;
- ret = led_classdev_register(&pdev->dev, &wrap_error_led);
+ ret = devm_led_classdev_register(&pdev->dev, &wrap_error_led);
if (ret < 0)
- goto err1;
-
- ret = led_classdev_register(&pdev->dev, &wrap_extra_led);
- if (ret < 0)
- goto err2;
-
- return ret;
+ return ret;
-err2:
- led_classdev_unregister(&wrap_error_led);
-err1:
- led_classdev_unregister(&wrap_power_led);
+ return devm_led_classdev_register(&pdev->dev, &wrap_extra_led);
- return ret;
}
-static int wrap_led_remove(struct platform_device *pdev)
-{
- led_classdev_unregister(&wrap_power_led);
- led_classdev_unregister(&wrap_error_led);
- led_classdev_unregister(&wrap_extra_led);
- return 0;
-}
static struct platform_driver wrap_led_driver = {
.probe = wrap_led_probe,
- .remove = wrap_led_remove,
.driver = {
.name = DRVNAME,
},
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: leds-wrap.c: Use devm_led_classdev_register
2015-10-21 10:58 [PATCH] leds: leds-wrap.c: Use devm_led_classdev_register Fida Mohammad
@ 2015-10-22 7:15 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2015-10-22 7:15 UTC (permalink / raw)
To: Fida Mohammad
Cc: Bryan Wu, Richard Purdie, linux-leds, LKML, Muhammad Falak,
Kristian Kielhofner
Hi Fida,
On 10/21/2015 12:58 PM, Fida Mohammad wrote:
> Use of resource managed function devm_led_classdev_register to
> make initialization path simpler. Also removed redundant remove
> function.
>
> Signed-off-by: Fida Mohammad <fmthoker@gmail.com>
> ---
> drivers/leds/leds-wrap.c | 26 ++++----------------------
> 1 file changed, 4 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/leds/leds-wrap.c b/drivers/leds/leds-wrap.c
> index 1ba3def..c5ff4b4 100644
> --- a/drivers/leds/leds-wrap.c
> +++ b/drivers/leds/leds-wrap.c
> @@ -76,39 +76,21 @@ static int wrap_led_probe(struct platform_device *pdev)
> {
> int ret;
>
> - ret = led_classdev_register(&pdev->dev, &wrap_power_led);
> + ret = devm_led_classdev_register(&pdev->dev, &wrap_power_led);
> if (ret < 0)
> return ret;
>
> - ret = led_classdev_register(&pdev->dev, &wrap_error_led);
> + ret = devm_led_classdev_register(&pdev->dev, &wrap_error_led);
> if (ret < 0)
> - goto err1;
> -
> - ret = led_classdev_register(&pdev->dev, &wrap_extra_led);
> - if (ret < 0)
> - goto err2;
> -
> - return ret;
> + return ret;
>
> -err2:
> - led_classdev_unregister(&wrap_error_led);
> -err1:
> - led_classdev_unregister(&wrap_power_led);
> + return devm_led_classdev_register(&pdev->dev, &wrap_extra_led);
>
Removed two extra empty lines end applied, thanks.
> - return ret;
> }
>
> -static int wrap_led_remove(struct platform_device *pdev)
> -{
> - led_classdev_unregister(&wrap_power_led);
> - led_classdev_unregister(&wrap_error_led);
> - led_classdev_unregister(&wrap_extra_led);
> - return 0;
> -}
>
> static struct platform_driver wrap_led_driver = {
> .probe = wrap_led_probe,
> - .remove = wrap_led_remove,
> .driver = {
> .name = DRVNAME,
> },
>
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-22 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-21 10:58 [PATCH] leds: leds-wrap.c: Use devm_led_classdev_register Fida Mohammad
2015-10-22 7:15 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).