From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756925AbbJVHPh (ORCPT ); Thu, 22 Oct 2015 03:15:37 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:14996 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754919AbbJVHPf (ORCPT ); Thu, 22 Oct 2015 03:15:35 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-35-56288d14e5c9 Message-id: <56288D13.3070108@samsung.com> Date: Thu, 22 Oct 2015 09:15:31 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Fida Mohammad Cc: Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org, LKML , Muhammad Falak , Kristian Kielhofner Subject: Re: [PATCH] leds: leds-wrap.c: Use devm_led_classdev_register References: <1445425115-5415-1-git-send-email-fmthoker@gmail.com> In-reply-to: <1445425115-5415-1-git-send-email-fmthoker@gmail.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsVy+t/xy7oivRphBg17LC2O7pzIZLH74XlW i9XfXzJZ/NzcwW5xedccNoutb9YxWuze9ZTVgd1j56y77B6Tr/WweuyZ/4PV4/MmuQCWKC6b lNSczLLUIn27BK6M+dP62QpO8FX8vXSGpYHxEXcXIyeHhICJxJ+rF5khbDGJC/fWs3UxcnEI CSxllNixdyuU84xR4uz+P6wgVbwCWhLTHx1jBLFZBFQlpryaywZiswkYSvx88ZoJxBYViJD4 c3ofVL2gxI/J91hAbBEBNYnLS/6A2cwC1xklvj8MArGFBdwktk7oBprJAbTMUaL/Zy1ImFPA SaLv/VyocmuJlZO2MULY8hKb17xlnsAoMAvJhllIymYhKVvAyLyKUTS1NLmgOCk911CvODG3 uDQvXS85P3cTIyS0v+xgXHzM6hCjAAejEg+vxn/1MCHWxLLiytxDjBIczEoivP8sNcKEeFMS K6tSi/Lji0pzUosPMUpzsCiJ887d9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwKj0x+GfBavOsYsM jdfPllkKhJfazbu+3ihi4zaBPTJum/fcWaB+IrEhzPKfjdfVnHrXO8xvzYKKv+700o+I31IZ 0Ru3Vufmk3sfJG2fGn6VPXRY6AKT0TdOtp8/c4rznjzJ/7UyOMa4dNKucobgfp3yhV8zkq5/ /iR0TZqn8iKb2MX8p+t1/yixFGckGmoxFxUnAgAXX3PSaQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fida, On 10/21/2015 12:58 PM, Fida Mohammad wrote: > Use of resource managed function devm_led_classdev_register to > make initialization path simpler. Also removed redundant remove > function. > > Signed-off-by: Fida Mohammad > --- > drivers/leds/leds-wrap.c | 26 ++++---------------------- > 1 file changed, 4 insertions(+), 22 deletions(-) > > diff --git a/drivers/leds/leds-wrap.c b/drivers/leds/leds-wrap.c > index 1ba3def..c5ff4b4 100644 > --- a/drivers/leds/leds-wrap.c > +++ b/drivers/leds/leds-wrap.c > @@ -76,39 +76,21 @@ static int wrap_led_probe(struct platform_device *pdev) > { > int ret; > > - ret = led_classdev_register(&pdev->dev, &wrap_power_led); > + ret = devm_led_classdev_register(&pdev->dev, &wrap_power_led); > if (ret < 0) > return ret; > > - ret = led_classdev_register(&pdev->dev, &wrap_error_led); > + ret = devm_led_classdev_register(&pdev->dev, &wrap_error_led); > if (ret < 0) > - goto err1; > - > - ret = led_classdev_register(&pdev->dev, &wrap_extra_led); > - if (ret < 0) > - goto err2; > - > - return ret; > + return ret; > > -err2: > - led_classdev_unregister(&wrap_error_led); > -err1: > - led_classdev_unregister(&wrap_power_led); > + return devm_led_classdev_register(&pdev->dev, &wrap_extra_led); > Removed two extra empty lines end applied, thanks. > - return ret; > } > > -static int wrap_led_remove(struct platform_device *pdev) > -{ > - led_classdev_unregister(&wrap_power_led); > - led_classdev_unregister(&wrap_error_led); > - led_classdev_unregister(&wrap_extra_led); > - return 0; > -} > > static struct platform_driver wrap_led_driver = { > .probe = wrap_led_probe, > - .remove = wrap_led_remove, > .driver = { > .name = DRVNAME, > }, > -- Best Regards, Jacek Anaszewski