From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755460AbbJVLqc (ORCPT ); Thu, 22 Oct 2015 07:46:32 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:36246 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbbJVLqa (ORCPT ); Thu, 22 Oct 2015 07:46:30 -0400 Subject: Re: [PATCH v2 5/6] vfio: platform: use list of registered reset function To: Arnd Bergmann References: <1445506922-6005-1-git-send-email-eric.auger@linaro.org> <1445506922-6005-6-git-send-email-eric.auger@linaro.org> <20554656.kA5nRBgtaJ@wuerfel> Cc: eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org, linux-kernel@vger.kernel.org, patches@linaro.org From: Eric Auger Message-ID: <5628CC93.7000801@linaro.org> Date: Thu, 22 Oct 2015 13:46:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20554656.kA5nRBgtaJ@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/2015 12:19 PM, Arnd Bergmann wrote: > On Thursday 22 October 2015 11:42:01 Eric Auger wrote: >> Remove the static lookup table and use the dynamic list of registered >> reset functions instead. Also load the reset module through its alias. >> The reset struct module pointer is stored in vfio_platform_device. >> >> We also remove the useless struct device pointer parameter in >> vfio_platform_get_reset. >> >> This patch fixes the issue related to the usage of __symbol_get, which >> besides from being moot, prevented compilation with CONFIG_MODULES >> disabled. >> >> Also usage of MODULE_ALIAS makes possible to add a new reset module >> without needing to update the framework. This was suggested by Arnd. >> >> Signed-off-by: Eric Auger >> Reported-by: Arnd Bergmann > > Looks good, just small style issues: > >> >> - } >> + mutex_lock(&reset_lock); >> + list_for_each_entry(iter, &reset_list, link) { >> + if (!strcmp(iter->compat, compat) && >> + try_module_get(iter->owner)) { >> + *module = iter->owner; >> + mutex_unlock(&reset_lock); >> + return iter->reset; >> } >> } >> + >> + mutex_unlock(&reset_lock); >> + return NULL; > > Better use 'break' to have a single mutex_unlock and return statement. OK > >> + >> >> static void vfio_platform_put_reset(struct vfio_platform_device *vdev) >> { >> - if (vdev->reset) >> - symbol_put_addr(vdev->reset); >> + if (vdev->reset) { >> + module_put(vdev->reset_module); >> + vdev->reset_module = NULL; >> + vdev->reset = NULL; >> + } >> } > > This gets called from the remove callback. No need to clear those > struct members immediately before the kfree(). I should have added those assignments in next patch actually. This latter moves the vfio_platform_put_reset call in the release function. Best Regards Eric > > Arnd >