From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756967AbbJVLyr (ORCPT ); Thu, 22 Oct 2015 07:54:47 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:37609 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbbJVLyq (ORCPT ); Thu, 22 Oct 2015 07:54:46 -0400 Subject: Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration To: Arnd Bergmann References: <1445506922-6005-1-git-send-email-eric.auger@linaro.org> <1445506922-6005-4-git-send-email-eric.auger@linaro.org> <4810974.apRDTjc3oB@wuerfel> Cc: eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org, linux-kernel@vger.kernel.org, patches@linaro.org From: Eric Auger Message-ID: <5628CE82.7090105@linaro.org> Date: Thu, 22 Oct 2015 13:54:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <4810974.apRDTjc3oB@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/2015 12:13 PM, Arnd Bergmann wrote: > On Thursday 22 October 2015 11:41:59 Eric Auger wrote: >> This patch adds the reset function registration/unregistration. >> >> Signed-off-by: Eric Auger > > Looks good, except one thing: >> @@ -70,6 +69,8 @@ int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev) >> return -ENOMEM; >> } >> >> + pr_info("VFIO reset of %s\n", vdev->name); >> + >> /* disable IRQ */ >> writel(0, reg.ioaddr + XGMAC_DMA_INTR_ENA); >> > > This probably slipped in from debugging, please remove it. Well actually this is not an oversight but some unappropriate tracing attempt I am afraid. I wanted to add a trace useful for the end-user to make sure the VFIO reset function was called. Do you forbid that or do recommend to use another tracing mechanism/level? In the past I tried dynamic tracing but with module loading mechanism I found it not that handy. Eric > > Arnd >