From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757378AbbJVM3I (ORCPT ); Thu, 22 Oct 2015 08:29:08 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:37116 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752215AbbJVM3G (ORCPT ); Thu, 22 Oct 2015 08:29:06 -0400 Subject: Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration To: Arnd Bergmann References: <1445506922-6005-1-git-send-email-eric.auger@linaro.org> <4810974.apRDTjc3oB@wuerfel> <5628CE82.7090105@linaro.org> <43557523.izmYB5ybOS@wuerfel> Cc: eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org, linux-kernel@vger.kernel.org, patches@linaro.org From: Eric Auger Message-ID: <5628D68E.5020009@linaro.org> Date: Thu, 22 Oct 2015 14:29:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <43557523.izmYB5ybOS@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/2015 02:09 PM, Arnd Bergmann wrote: > On Thursday 22 October 2015 13:54:42 Eric Auger wrote: >> On 10/22/2015 12:13 PM, Arnd Bergmann wrote: >>> On Thursday 22 October 2015 11:41:59 Eric Auger wrote: >>>> This patch adds the reset function registration/unregistration. >>>> >>>> Signed-off-by: Eric Auger >>> >>> Looks good, except one thing: >>>> @@ -70,6 +69,8 @@ int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev) >>>> return -ENOMEM; >>>> } >>>> >>>> + pr_info("VFIO reset of %s\n", vdev->name); >>>> + >>>> /* disable IRQ */ >>>> writel(0, reg.ioaddr + XGMAC_DMA_INTR_ENA); >>>> >>> >>> This probably slipped in from debugging, please remove it. >> Well actually this is not an oversight but some unappropriate tracing >> attempt I am afraid. I wanted to add a trace useful for the end-user to >> make sure the VFIO reset function was called. Do you forbid that or do >> recommend to use another tracing mechanism/level? In the past I tried >> dynamic tracing but with module loading mechanism I found it not that handy. > > If you think it's useful to have in the long run, it should be a separate > patch with a description what it's good for, rather than a side-effect of > an unrelated patch. It just looked to me like it's something you do > while debugging the reset code, rather than while using it. > > Implementation-wise, you should use dev_info() instead of pr_info() where > possible, and it probably makes sense to put this into the vfio_platform > driver before calling the reset function, for consistency between the > drivers. OK thanks Best Regards Eric > > Arnd >