From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758040AbbJVSfI (ORCPT ); Thu, 22 Oct 2015 14:35:08 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:34274 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757791AbbJVSfF (ORCPT ); Thu, 22 Oct 2015 14:35:05 -0400 Subject: Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 To: Punit Vara , jirislaby@gmail.com References: <1445538363-2893-1-git-send-email-punitvara@gmail.com> Cc: mickflemm@gmail.com, mcgrof@do-not-panic.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56292C55.4030706@cogentembedded.com> Date: Thu, 22 Oct 2015 21:35:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1445538363-2893-1-git-send-email-punitvara@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 10/22/2015 09:26 PM, Punit Vara wrote: > This patch is to the ath5k/eeprom.c that fixes up warning caught by > coccicheck: > > -Unneeded variable: "ret". Return "0" on line 1733 > > Remove unneccesary variable ret created to return zero. > > Also removed empty line suggested by Sergei > > Signed-off-by: Punit Vara > --- > drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/eeprom.c b/drivers/net/wireless/ath/ath5k/eeprom.c > index 94d34ee..0c82ea5 100644 > --- a/drivers/net/wireless/ath/ath5k/eeprom.c > +++ b/drivers/net/wireless/ath/ath5k/eeprom.c > @@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah) > struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom; > u32 offset; > u16 val; > - int ret = 0, i; > - No, this one shouldn't have been removed. There should an empty line between the declarations and the statements. > + int i; > offset = AR5K_EEPROM_CTL(ee->ee_version) + > AR5K_EEPROM_N_CTLS(ee->ee_version); > MBR, Sergei