From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752573AbbJWDsF (ORCPT ); Thu, 22 Oct 2015 23:48:05 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:35228 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbbJWDsD (ORCPT ); Thu, 22 Oct 2015 23:48:03 -0400 Message-ID: <5629ADC8.20009@huawei.com> Date: Fri, 23 Oct 2015 11:47:20 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Alexei Starovoitov , "David S. Miller" CC: Ingo Molnar , Peter Zijlstra , He Kuang , Kaixu Xia , "Daniel Borkmann" , , Subject: Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper References: <1445559014-4667-1-git-send-email-ast@kernel.org> In-Reply-To: <1445559014-4667-1-git-send-email-ast@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/10/23 8:10, Alexei Starovoitov wrote: > Fix safety checks for bpf_perf_event_read(): > - only non-inherited events can be added to perf_event_array map > (do this check statically at map insertion time) > - dynamically check that event is local and !pmu->count > Otherwise buggy bpf program can cause kernel splat. > > Also fix error path after perf_event_attrs() > and remove redundant 'extern'. > > Fixes: 35578d798400 ("bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter") > Signed-off-by: Alexei Starovoitov Tested-by: Wang Nan