From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751208AbbJWEtn (ORCPT <rfc822;w@1wt.eu>);
	Fri, 23 Oct 2015 00:49:43 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:2074 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750793AbbJWEtm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 23 Oct 2015 00:49:42 -0400
Message-ID: <5629BC29.9070601@huawei.com>
Date: Fri, 23 Oct 2015 12:48:41 +0800
From: "Wangnan (F)" <wangnan0@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: <acme@kernel.org>, <ast@plumgrid.com>, <brendan.d.gregg@gmail.com>
CC: <a.p.zijlstra@chello.nl>, <daniel@iogearbox.net>, <dsahern@gmail.com>,
        <hekuang@huawei.com>, <jolsa@kernel.org>, <lizefan@huawei.com>,
        <masami.hiramatsu.pt@hitachi.com>, <namhyung@kernel.org>,
        <paulus@samba.org>, <linux-kernel@vger.kernel.org>, <pi3orama@163.com>,
        <xiakaixu@huawei.com>, Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [RFC PATCH 4/7] perf tools: Enable BPF object configure syntax
References: <1445078910-73699-1-git-send-email-wangnan0@huawei.com> <1445078910-73699-5-git-send-email-wangnan0@huawei.com>
In-Reply-To: <1445078910-73699-5-git-send-email-wangnan0@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020205.5629BC3B.00D4,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 2e29eddbbd7edbd4b27271857f21c5aa
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2015/10/17 18:48, Wang Nan wrote:

[SNIP]
>   
>   event_bpf_file:
> -PE_BPF_OBJECT
> +PE_BPF_OBJECT event_bpf_config
>   {
>   	struct parse_events_evlist *data = _data;
>   	struct parse_events_error *error = data->error;
>   	struct list_head *list;
>   
>   	ALLOC_LIST(list);
> -	ABORT_ON(parse_events_load_bpf(data, list, $1, false));
> +	ABORT_ON(parse_events_load_bpf(data, list, $1, false, $2));
> +	parse_events__free_terms($2);

Here found a bug that $2 is possible to be NULL, but parse_events_free_terms
can't accept NULL param.

Will be fixed in next version.

Thank you.

>   	$$ = list;
>   }
>   |
> -PE_BPF_SOURCE
> +PE_BPF_SOURCE event_bpf_config
>   {
>   	struct parse_events_evlist *data = _data;
>   	struct list_head *list;
>   
>   	ALLOC_LIST(list);
> -	ABORT_ON(parse_events_load_bpf(data, list, $1, true));
> +	ABORT_ON(parse_events_load_bpf(data, list, $1, true, $2));
> +	parse_events__free_terms($2);
>   	$$ = list;
>   }
>   
> +event_bpf_config:
> +'/' event_config '/'
> +{
> +	$$ = $2;
> +}
> +|
> +{
> +	$$ = NULL;
> +}
> +
>   start_terms: event_config
>   {
>   	struct parse_events_terms *data = _data;