From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbbJWMKr (ORCPT ); Fri, 23 Oct 2015 08:10:47 -0400 Received: from mail1.bemta12.messagelabs.com ([216.82.251.9]:36362 "EHLO mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbbJWMKp (ORCPT ); Fri, 23 Oct 2015 08:10:45 -0400 X-Env-Sender: Marc_Gonzalez@sigmadesigns.com X-Msg-Ref: server-5.tower-219.messagelabs.com!1445602236!4263657!1 X-Originating-IP: [195.215.56.170] X-StarScan-Received: X-StarScan-Version: 7.19.2; banners=-,-,- X-VirusChecked: Checked Subject: Re: [PATCH 2/3] devicetree: add binding for Aurora VLSI NB8800 Ethernet controller To: Kumar Gala , References: <1445522558-5808-1-git-send-email-mans@mansr.com> <1445522558-5808-2-git-send-email-mans@mansr.com> CC: Mans Rullgard , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , , Sebastian Frias , Thibaud Cornic , Mason From: Marc Gonzalez Message-ID: <562A23B9.3090208@sigmadesigns.com> Date: Fri, 23 Oct 2015 14:10:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 SeaMonkey/2.38 MIME-Version: 1.0 In-Reply-To: <1445522558-5808-2-git-send-email-mans@mansr.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.27.0.114] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/10/2015 16:02, Mans Rullgard wrote: > This adds a binding for the Aurora VLSI NB8800 Ethernet controller > using the "aurora,nb8800" compatible string. When used in Sigma > Designs chips a few additional control registers are available. > This variant is indicated by the "sigma,smp8640-ethernet" compatible > string. > > Signed-off-by: Mans Rullgard > --- > .../devicetree/bindings/net/aurora,nb8800.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/aurora,nb8800.txt > > diff --git a/Documentation/devicetree/bindings/net/aurora,nb8800.txt b/Documentation/devicetree/bindings/net/aurora,nb8800.txt > new file mode 100644 > index 0000000..c19f615 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/aurora,nb8800.txt > @@ -0,0 +1,26 @@ > +* Aurora VLSI AU-NB8800 Ethernet controller > + > +Required properties: > +- compatible: Should be "aurora,nb8800", "sigma,smp8640-ethernet" > + The latter indicates presence of extra features added by Sigma Designs. I've been meaning to ask a noob question to the devicetree group about how names for compatible strings are chosen. Sigma Designs has two active SoC families, Tango3 (which consists of about a dozen MIPS-based SoCs, typically named SMP86xx) and Tango4 (a few ARM-based SoCs, typically named SMP87xx). I should note that there is no SMP8640 SoC AFAIK, rather SMP864x is a Tango3 sub-family (I could locate 42,43,44,45,46). AFAIK, all our SoCs are using the same Aurora NB8800 Ethernet MAC, along with the extra features. I find it odd to use a specific SoC model to refer to this device, instead of a more generic name. (It's weird having to mention smp8640 in the tango4 DT.) Would it be possible to have a compatible string which makes it clear that it is an Aurora MAC with vendor-specific tweaks? Something like "sigma,aurora-nb8800-mac" ? > +- reg: Should be MMIO address space of the device > +- interrupts: Should contain the interrupt specifier for the device > +- interrupt-parent: Should be a phandle for the interrupt controller > +- clocks: Should be a phandle for the clock for the device > + > +Common properties described in ethernet.txt: > +- local-mac-address > +- mac-address > +- max-speed > +- phy-mode > + > +Example: > + > +ethernet@26000 { > + compatible = "aurora,nb8800"; > + reg = <0x10000 0x800>; > + interrupts = <42>; I thought one had to specify also whether the device sent "edge" or "level" IRQs? > + clocks = <&sys_clk>; > + max-speed = <1000>; > + phy-connection-type = "rgmii"; > +}; Regards.