From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752677AbbJWNpm (ORCPT <rfc822;w@1wt.eu>);
	Fri, 23 Oct 2015 09:45:42 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:16026 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752165AbbJWNpl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 23 Oct 2015 09:45:41 -0400
X-IronPort-AV: E=Sophos;i="5.20,186,1444694400"; 
   d="scan'208";a="312558782"
Message-ID: <562A3A00.60509@citrix.com>
Date: Fri, 23 Oct 2015 14:45:36 +0100
From: David Vrabel <david.vrabel@citrix.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0
MIME-Version: 1.0
To: Julien Grall <julien.grall@citrix.com>, <xen-devel@lists.xenproject.org>,
        <linux-kernel@vger.kernel.org>
CC: <linux-mm@kvack.org>, David Vrabel <david.vrabel@citrix.com>
Subject: Re: [Xen-devel] [PATCH] mm: hotplug: Don't release twice the resource
 on error
References: <1445605053-23274-1-git-send-email-julien.grall@citrix.com>
In-Reply-To: <1445605053-23274-1-git-send-email-julien.grall@citrix.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 23/10/15 13:57, Julien Grall wrote:
> The function add_memory_resource take in parameter a resource allocated
> by the caller. On error, both add_memory_resource and the caller will
> release the resource via release_memory_source.
[...]
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1298,7 +1298,6 @@ error:
>  	/* rollback pgdat allocation and others */
>  	if (new_pgdat)
>  		rollback_node_hotadd(nid, pgdat);
> -	release_memory_resource(res);
>  	memblock_remove(start, size);

I've folded this in, thanks.

David