From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751117AbbJWN4A (ORCPT ); Fri, 23 Oct 2015 09:56:00 -0400 Received: from mga03.intel.com ([134.134.136.65]:34158 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbbJWNz7 (ORCPT ); Fri, 23 Oct 2015 09:55:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,186,1444719600"; d="scan'208";a="833452492" Message-ID: <562A3C6B.6070304@linux.intel.com> Date: Fri, 23 Oct 2015 16:55:55 +0300 From: Jarkko Nikula User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Mika Westerberg , Wolfram Sang CC: Dustin Byford , Jean Delvare , Andy Shevchenko , linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, rjw@rjwysocki.net, "Puustinen, Ismo" Subject: Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports References: <1439510358-16664-1-git-send-email-dustin@cumulusnetworks.com> <1445505462-27915-1-git-send-email-dustin@cumulusnetworks.com> <1445505462-27915-3-git-send-email-dustin@cumulusnetworks.com> <20151023084013.GS1526@lahna.fi.intel.com> <20151023101611.GH13380@katana> <20151023131311.GA1526@lahna.fi.intel.com> <20151023134004.GB1526@lahna.fi.intel.com> In-Reply-To: <20151023134004.GB1526@lahna.fi.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2015 04:40 PM, Mika Westerberg wrote: > On Fri, Oct 23, 2015 at 04:13:11PM +0300, Mika Westerberg wrote: >> On Fri, Oct 23, 2015 at 12:16:11PM +0200, Wolfram Sang wrote: >>> On Fri, Oct 23, 2015 at 11:40:13AM +0300, Mika Westerberg wrote: >>>> On Thu, Oct 22, 2015 at 02:17:42AM -0700, Dustin Byford wrote: > Ah, forgot to mention that the i2c-designware-pcidrv.c misses include of > so that needs to be fixed. Otherwise we get: > > drivers/i2c/busses/i2c-designware-pcidrv.c: In function ‘i2c_dw_pci_probe’: > drivers/i2c/busses/i2c-designware-pcidrv.c:259:2: error: implicit declaration of function ‘ACPI_COMPANION_SET’ [-Werror=implicit-function-declaration] > drivers/i2c/busses/i2c-designware-pcidrv.c:259:33: error: implicit declaration of function ‘ACPI_COMPANION’ [-Werror=implicit-function-declaration] > Please also check that patches apply on top of i2c/for-next due recently applied cleanup patches from me. I think commit d80d134182ba ("i2c: designware: Move common probe code into i2c_dw_probe()") makes your patch only a 2 liner to drivers/i2c/busses/i2c-designware-core.c :-) -- Jarkko