From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751886AbbJWOLG (ORCPT ); Fri, 23 Oct 2015 10:11:06 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:37982 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbbJWOLE (ORCPT ); Fri, 23 Oct 2015 10:11:04 -0400 Subject: Re: [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <1445603835-14506-1-git-send-email-eric.auger@linaro.org> <1445603835-14506-4-git-send-email-eric.auger@linaro.org> <3721718.lcvGuESNdi@wuerfel> Cc: eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, christoffer.dall@linaro.org, patches@linaro.org From: Eric Auger Message-ID: <562A3FF3.5040004@linaro.org> Date: Fri, 23 Oct 2015 16:10:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <3721718.lcvGuESNdi@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 10/23/2015 03:09 PM, Arnd Bergmann wrote: > On Friday 23 October 2015 14:37:11 Eric Auger wrote: >> +static int __init reset ## _module_init(void) \ >> +{ \ >> + vfio_platform_register_reset(compat, reset); \ >> + return 0; \ >> +}; \ >> > > I would make this 'return vfio_platform_register_reset(...)', so loading > the driver fails if the handler cannot get registered. Alternatively, > change the return type of vfio_platform_register_reset to 'void' > so it can never fail. I will turn __vfio_platform_register_reset to 'void' then since it has no reason to fail now. Thanks Eric > > Arnd >