Re: [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro

Eric Auger
2015-10-23T14:11:06Z

Hi Arnd,
On 10/23/2015 03:09 PM, Arnd Bergmann wrote:
> On Friday 23 October 2015 14:37:11 Eric Auger wrote:
>> +static int __init reset ## _module_init(void) \
>> +{ \
>> + vfio_platform_register_reset(compat, reset); \
>> + return 0; \
>> +}; \
>>
>
> I would make this 'return vfio_platform_register_reset(...)', so loading
> the driver fails if the handler cannot get registered. Alternatively,
> change the return type of vfio_platform_register_reset to 'void'
> so it can never fail.
I will turn __vfio_platform_register_reset to 'void' then since it has
no reason to fail now.

Thanks

Eric

>
> Arnd
>