From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752334AbbJWOLT (ORCPT ); Fri, 23 Oct 2015 10:11:19 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:38152 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144AbbJWOLQ (ORCPT ); Fri, 23 Oct 2015 10:11:16 -0400 Subject: Re: [PATCH v3 6/7] vfio: platform: use list of registered reset function To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <1445603835-14506-1-git-send-email-eric.auger@linaro.org> <1445603835-14506-7-git-send-email-eric.auger@linaro.org> <4934120.DeNtNjTIFs@wuerfel> Cc: eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, christoffer.dall@linaro.org, patches@linaro.org From: Eric Auger Message-ID: <562A3FFC.4050504@linaro.org> Date: Fri, 23 Oct 2015 16:11:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <4934120.DeNtNjTIFs@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 10/23/2015 03:12 PM, Arnd Bergmann wrote: > On Friday 23 October 2015 14:37:14 Eric Auger wrote: >> Remove the static lookup table and use the dynamic list of registered >> reset functions instead. Also load the reset module through its alias. >> The reset struct module pointer is stored in vfio_platform_device. >> >> We also remove the useless struct device pointer parameter in >> vfio_platform_get_reset. >> >> This patch fixes the issue related to the usage of __symbol_get, which >> besides from being moot, prevented compilation with CONFIG_MODULES >> disabled. >> >> Also usage of MODULE_ALIAS makes possible to add a new reset module >> without needing to update the framework. This was suggested by Arnd. >> >> Signed-off-by: Eric Auger >> Reported-by: Arnd Bergmann >> >> > Reviewed-by: Arnd Bergmann > > but doesn't this need to come before patch 4/7? Well I don't think so. In [4] we introduce the dynamic registration method but until this patch we still use the old lookup method in the static table. I tested and the reset lookup still works in [4]. If we put this one before the registration, the functionality will be lost here. Eric > Arnd >